Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test case for false positive #419

Merged
merged 2 commits into from
Apr 9, 2022

Conversation

tasomaniac
Copy link
Contributor

There was one false-positive in our project. Instead of opening an issue, I thought it would be better to have a failing test case.

If a dependant module uses resValue, then the generated resource usage is not detected.

@tasomaniac tasomaniac requested a review from RBusarow as a code owner February 26, 2022 23:52
@RBusarow
Copy link
Member

RBusarow commented Mar 1, 2022

Thanks for the test!

I'll be getting to this very soon.

@RBusarow RBusarow marked this pull request as draft March 1, 2022 15:30
@tasomaniac
Copy link
Contributor Author

Marking it as draft makes sense 😅

I actually tried to fix it. One thing that I realized is that you have a task dependency to buildConfig tasks but not to resValues. Very similarly in couple of lines, I did this but it did not help.

I debugged (by putting bunch of print statements 😂) everything seems to be fine but the resources source sets somehow do not include the generated resources folder. I couldn't figure out why.

@RBusarow
Copy link
Member

@dependabot recreate

@RBusarow RBusarow force-pushed the take-resValue-into-account branch from b1fe6ac to f47195d Compare April 9, 2022 21:15
@RBusarow RBusarow marked this pull request as ready for review April 9, 2022 21:15
@kodiakhq kodiakhq bot merged commit 4423ab8 into rickbusarow:main Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants