Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the alternative usage of kapt plugin #481

Merged

Conversation

tasomaniac
Copy link
Contributor

@tasomaniac tasomaniac commented Mar 27, 2022

In our project, the line numbers were not shown correctly. I figured out we had another was of adding kapt plugin.

FYI: All Kotlin plugins have 3 different way of applying: 2 ids and 1 function.

Btw, @Suppress annotation also did not work for Kapt but I didn't have a chance to reproduce that. I'm hoping that this also fixes that issue.

@tasomaniac tasomaniac requested a review from RBusarow as a code owner March 27, 2022 16:05
Copy link
Member

@RBusarow RBusarow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! And sorry for the late review...

A lot of this "unused kapt" stuff is carried over from an internal plugin which predated ModuleCheck. I'm afraid I kind of shoe-horned it into this project. One of these days I'll rewrite the whole thing.

@kodiakhq kodiakhq bot merged commit 8ec9774 into rickbusarow:main Apr 4, 2022
@tasomaniac
Copy link
Contributor Author

No worries, it works and it doesn't have to be perfect as long as it adds value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants