-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCHIP-01: Add bytesToHex method #11
Comments
The original intent of this RChip 09 was to address the implementation of bytesToHex. |
@SteveHenley |
I see this is cited by rchain/rchain#2918 please reduce the scope and update the title for Also, this seems to be missing much of the information required by the RCHIP draft from the 2018 annual meeting:
I don't suppose that was ever ratified, but I haven't seen anything that supersedes it. Who is on the Editorial Committee? the Approval Committee? p.s. for follow-up on process, see #14 |
To clarify, if you are request that the title for RChip 09 be updates to byesToHex only, then here is Rao's reply: There is currently no editorial committee nor approval committee. Due to the limited manpower the tech governance working group decided to go with lighter version of the RChip. Rao can better explain what this lighter version is. @dckc |
rchain/rchain#2918 doesn't cover Exposing Scala regular expressions. It's just As to "agreed scope", please cite the decision record. I don't believe anyone has mandate to make such decisions on behalf of the coop or even on behalf of me. |
To avoid ReDoS attacks and pricing issues with regular expressions we can provide basic pattern matching by supporting unix file glob patterns. https://en.wikipedia.org/wiki/Glob_(programming) Regular expression might best be implimented as rholang patterns rather than strings in a separate RChip |
Given the lack of full regular expression support a frequent requirement is for tolowercase(String) so that rchain can support case insensitive strings and "Jim" tolowercase can be compared to be equal to "jim". |
As a result of the last tech governance session discussionsI have updated the title of RChip-09 to Improve string function: bytesToHex so that it is more narrow in focus. |
Update title to be more concise based comments above and tech governance discussion. |
I have created a google docs RChip-09-bytesToHex for us to collaborate. |
@tgrospic I just noticed the Approved label here; that's not a judgement you made unilaterally, right? I suspect the decision was made by the tech governance group. Please cite the record of that decision. (Or make a record of it here, noting when it was made and who participated. Enumerating yes / no / abstain is traditional too) |
@dckc I added label Approved after PR was merged. I agreed to approve the PR after decision on the tech governance group. We decided to be less demanding on the proposal description because working code is already created. I suggested that we use emoticons (:+1: :-1:) in the description (?). |
@dckc Please refer to the Log: Tech Governance, date 2020-06-25, agenda item #4 regarding the approval of RCHIP-01: Add byesToHex Method and all subsequence RCHIPs and RCHIP issues. |
OK. If everything is approved, I trust you'll get rid of the Approved label, since it doesn't mean anything. |
Specify expressions for string (Aurthur Greef PR merge - convert into RChip)
Dappy needs Scala regular expressions to be exposed in Rholang - e.g. to check for domain names
https://www.tutorialspoint.com/scala/scala_regular_expressions.htm
The text was updated successfully, but these errors were encountered: