Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential bug when using timestamp #26

Open
rdemaria opened this issue Dec 20, 2016 · 0 comments
Open

potential bug when using timestamp #26

rdemaria opened this issue Dec 20, 2016 · 0 comments
Labels

Comments

@rdemaria
Copy link
Owner

rdemaria commented Dec 20, 2016

I think the lines

tt = datetime.datetime.fromtimestamp(t)
ts = Timestamp.valueOf(tt.strftime('%Y-%m-%d %H:%M:%S.%f'))

in toTimestamp(self, t): are sick

because going to string loses the summer time information. I think we should use native Java methods:
e.g. Timestamp.from_(Date(tt).toInstant ())

@xbuffat is looking into that now...

@rdemaria rdemaria added the bug label Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant