This repository has been archived by the owner on Mar 7, 2024. It is now read-only.
Metadata tests followup #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
===========================================
+ Coverage 52.06% 70.72% +18.66%
===========================================
Files 7 7
Lines 1281 1288 +7
===========================================
+ Hits 667 911 +244
+ Misses 540 305 -235
+ Partials 74 72 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
rdimitrov
reviewed
Aug 14, 2023
|
Thanks @rdimitrov. The CI fails running the examples with There is a go-linter check that I'll fix and push. |
|
Go linter is fixed. |
rdimitrov
reviewed
Aug 18, 2023
Previously Targets' `AddKey(key, role)` was returning error that role doesn't exist in the case when role exists and already has that key. This change fixes that and alligns the function with the python-tuf reference implementation, where the key is added to delegations, even if it's not added to Roles and SuccinctRoles Signed-off-by: Ivana Atanasova <iyovcheva@vmware.com>
Previously the target file path hash was not base64 URL encoded which ended up to not being able to properly compare if role's PathHashPrefixes contains a prefix of that hash. This change fixes the encoding Signed-off-by: Ivana Atanasova <iyovcheva@vmware.com>
This allows testing if the suffix len is properly calculated in the metadata Signed-off-by: Ivana Atanasova <iyovcheva@vmware.com>
This change changes the targets files used for targets metadata to be simplified and neutral for the purpose of more clear and less mistake-prone test cases. It also adds new keys for additional metadata api testing Signed-off-by: Ivana Atanasova <iyovcheva@vmware.com>
This change completes the metadata api test coverage with reference to the python-tuf implementations, excluding few use- cases that are not applicable Signed-off-by: Ivana Atanasova <iyovcheva@vmware.com>
This fixes few error checks that were not handled in the metadata api tests Signed-off-by: Ivana Atanasova <iyovcheva@vmware.com>
This change provides tiny updates of two metalada helper functions to giarantee more stable testing over time Signed-off-by: Ivana Atanasova <iyovcheva@vmware.com>
ivanayov
force-pushed
the
metadata_tests_followup
branch
from
45e3e95
to
b30c860
Compare
|
Thanks @rdimitrov, just pushed the updates and rebased with the fixed CI. |
rdimitrov
approved these changes
Aug 18, 2023
kipz
pushed a commit
to kipz/go-tuf-metadata
that referenced
this pull request
Jan 29, 2024
* Fix AddKey for targets Previously Targets' `AddKey(key, role)` was returning error that role doesn't exist in the case when role exists and already has that key. This change fixes that and alligns the function with the python-tuf reference implementation, where the key is added to delegations, even if it's not added to Roles and SuccinctRoles Signed-off-by: Ivana Atanasova <iyovcheva@vmware.com> * Fix delegated path prefix check Previously the target file path hash was not base64 URL encoded which ended up to not being able to properly compare if role's PathHashPrefixes contains a prefix of that hash. This change fixes the encoding Signed-off-by: Ivana Atanasova <iyovcheva@vmware.com> * Add SuccinctRoles.GetSuffixLen() for the purpose of testing This allows testing if the suffix len is properly calculated in the metadata Signed-off-by: Ivana Atanasova <iyovcheva@vmware.com> * Add test repository data improvements This change changes the targets files used for targets metadata to be simplified and neutral for the purpose of more clear and less mistake-prone test cases. It also adds new keys for additional metadata api testing Signed-off-by: Ivana Atanasova <iyovcheva@vmware.com> * Add more metadata api tests This change completes the metadata api test coverage with reference to the python-tuf implementations, excluding few use- cases that are not applicable Signed-off-by: Ivana Atanasova <iyovcheva@vmware.com> * Fix go linter checks for metadata api tests This fixes few error checks that were not handled in the metadata api tests Signed-off-by: Ivana Atanasova <iyovcheva@vmware.com> * Improve metadata hepler test functions usage This change provides tiny updates of two metalada helper functions to giarantee more stable testing over time Signed-off-by: Ivana Atanasova <iyovcheva@vmware.com> --------- Signed-off-by: Ivana Atanasova <iyovcheva@vmware.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change completes the metadata api test coverage with reference to the python-tuf implementation, excluding few use-cases that are not applicable
Provides two small metadata fixes and an improved test repository data.