Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout improvements for discussion #254

Open
leucoryx opened this issue Sep 25, 2020 · 3 comments
Open

Layout improvements for discussion #254

leucoryx opened this issue Sep 25, 2020 · 3 comments
Labels
priority:low

Comments

@leucoryx
Copy link
Collaborator

  1. Hilfetext zu Beschreibung und Katalog wie z.B. “Der Fragenkatalog der für dieses Projekt verwendet wird.“ sollte oben drüber stehen, nicht unten drunter, konsistenz zu wie es auch im Fragenkatalog bei Fragen gehandhabt wird.
  2. Projekt anlegen. Titel kann als value project/title bei Ansichten ausgelesen werden. Wenn auch eine Frage mit attribut project/title angelegt wird, wird der value dort aber nicht übernommen. Wieso? Gäbe es diese Möglichkeit? Wie ist das technisch umgesetzt?
  3. “Weiteren” Stellvertreter hinzufügen, „Weiteres Schlagwort hinzufügen“ etc., um es klarer zu machen
  4. „Fragen beantworten“ zu wenig prominent, dafür, dass es die erste Aktion des Nutzers sein sollte.
  5. Aufgaben leer irritiert beim ersten Aufruf. Unklar, was das soll. Erwartung, dass man selber Aufgaben anlegen kann -> Text ändern in "Keine aktiven Aufgaben gefunden. Bitte beantworten Sie zunächst die Fragen im Fragenkatalog, indem Sie im Menü „Fragen beantworten“ klicken. Aus Ihrer Beantwortung der Fragen werden notwendige Aufgaben generiert"
  6. Ansichten sollte lieber “Formulare” oder ähnliches heißen. Wording “Ansicht” ist unklar / Unklar, dass Fragen/Antworten die Ansicht befüllen.
  7. „Katalog“ ist unklar. Evtl. ändern in „Fragenkatalog“
  8. “Snapshot” ist unklar, ist das eine Vorschau/ein Stand? kurze Erklärungstexte
  9. “Mitgliedschaften” Formulierung unpassend -> Mitglieder?
  10. Katalogauswahl per Dropdownmenü
  11. Pflichtfelder und optionale Felder vorgeben können
  12. Filtern von Fragen auf aktueller Seite ermöglichen und je nach Antwortauswahl Fragen dazu ein-/ausblenden.
    Nice-to-have
  13. “Sichern” und “Sichern und fortfahren” Wording ist unklar → Speichern und Speichern und fortfahren
  14. Beschreibung → Hilfetext, was hier rein soll. Sollte dort tatsächlich nur optional stehen?
  15. Beim Menü rechts “Projektinformationen bearbeiten” aber “Projekt Aufgaben” und “Projekt Ansichten”. Konsistenter und eingängiger wäre “Projektaufgaben” “Projektansichten” etc.
  16. Bei Select File sollte vorausgewählt sein, dass nur xml files gehen
  17. “Zur nächsten Seite springen” müsste es heißen, zur nächsten Frage würde implizieren, dass man auf der aktuellen Seite bleibt und zur nächsten Frage springt (im Englischen ist es richtig)
  18. Fortschrittsbalken beim beantworten der Fragen durch zahlen verstärken (seite x von y)
  19. Kalender sollte mit Mo anfangen, nicht mit Sonntag
@YvanaGlasenapp
Copy link

I agree with the suggested improvements; especially number 4, a more prominent start-button.

@YvanaGlasenapp
Copy link

In addition, it would be good to add chapter numbers for the chapters and sub-chapters in the generic catalogue.

@m6121 m6121 mentioned this issue Nov 19, 2021
Merged
This was referenced Oct 16, 2023
Open
Open
Open
@jochenklar
Copy link
Member

jochenklar commented Oct 16, 2023 •
edited
Loading

As of October 23:

  1. already implemented
  2. this is not possible, we could use something else than project/title, but I would rather advise people not to use that attribute.
  3. The translated buttons will be updated in 2.1.0, but with less text, since it causes trouble with translations. It will be only "+ Stellvertreter".
  4. We moved this to the top of the sidebar, but maybe it will be changed again in an overhaul of the project page.
  5. The help text was already adjusted.
  6. The term view/Ansicht is now pretty established in the community. We might combine "Antworten anzeigen" with the views in the future though.
  7. We should discuss this in the community. Separate Issue: Rename catalog/Katalog questionaire/Fragenkatalog on the project page #781 this.
  8. The help text was already adjusted.
  9. Again, needs to be discussed. The help text was already adjusted. Separate Issue: Rename Memberships/Mitgliedschaften to Members/Mitglieder on the project page #782.
  10. Already implemented as an external template. https://github.com/jochenklar/rdmo.jochenklar.de/blob/master/rdmo_jochenklar/templates/projects/project_detail_header_catalog.html
  11. Already implemented.
  12. If this is part of the management, then it is already implemented. For the interview, I don't see the point.
  13. Already implemented.
  14. Already implemented.
  15. Will be fixed in 2.1.0.
  16. Will be fixed in 2.1.0.
  17. Not relevant anymore, because of the change to the buttons.
  18. A "new" progress bar will be part of 2.1.0
  19. Already implemented.

Regarding @YvanaGlasenapp idea we would need to discuss that with the community as well. Separate Issue: #783.

jochenklar added a commit that referenced this issue Oct 16, 2023
@jochenklar
Fix translated strings (Projektaufgaben, Projektansichten) and some
d40f9af 
automatic reformatting (#254)
@jochenklar jochenklar mentioned this issue Oct 16, 2023
Merged
jochenklar added a commit that referenced this issue Nov 23, 2023
@jochenklar
Fix translated strings (Projektaufgaben, Projektansichten) and some
a8d92c1 
automatic reformatting (#254)
afuetterer added a commit to afuetterer/rdmo that referenced this issue Nov 29, 2023
@afuetterer @jochenklar
@MyPyDavid @github-actions @dependabot
Update js dependencies (#144)
8daba98 
* Refactor autocomplete and add free autocomplete widget for arbitrary inputs (rdmorganiser#600)

* refactor: use admin.register decorator

* build: pin django-mptt dependency

* fix: update verbose_name_plural in questionset

* fix rdmorganiser#791 for openid_connect providers and refactor keycloak snippet

* Add custom {more} markdown tag (rdmorganiser#595)

* Adjust details/summary style

* Add ValueConflictValidator and check for conflicts when storing values

* Autosave after eraseValue and removeValue

* Add tests for ValueConflictValidator

* Fix human2bytes utils function

* chore: refactor human2bytes utils func

* Fix ValueQuotaValidator and add tests

* Update HUMAN2BYTES_MAPPER and add test

* Refactor progress bar and take sets and conditions into account (rdmorganiser#596)

* Check is_optional for progress bar (again)

* Add progress_count and progress_total to Project model, compute on POST
when using the API and add progress to the project overview (rdmorganiser#488)

* Add navigation action to ProjectViewSet and refactor navigation (rdmorganiser#299, rdmorganiser#424)

* Always show count in progress bar

* Fix progress bar for questionsets

* Fix progress computation

* Fix progress permissions

* Add tests for progress and navigation

* Add progress to project hierarchy (rdmorganiser#488)

* chore: refactor values query to managers

* Use "count of total" for the progress in projects table

* Add support for BASE_URL to the management react interface (rdmorganiser#815)

* Rename variable

* Refresh navigation after auto-save in interview

* chore: add pytest-playwright dependency

* chore: add custom pytest marker for e2e tests

* chore: enable debug mode per env, default false

* refactor: add "fixtures" fixture to reuse in e2e tests

* test: add frontend-tests with pytest-playwright

Co-authored-by: David Wallace

Fixes: rdmorganiser#715

* ci: run e2e tests in ci

* ci: add build-wheel job

Fixes: rdmorganiser#802

* Fix translated strings (Projektaufgaben, Projektansichten) and some
automatic reformatting (rdmorganiser#254)

* Add accept to project import plugins to restrict upload files (to e.g. .xml)

* Add accept=".xml" to management upload form component

* chore: add email to RoleAdmin

* chore: update ruff repo name in pre-commit config

* build: update pre-commit hooks

* chore: fix ruff errors (PGH002, UP032)

* ci: add dependency groups to dependabot config

* ci: update dependabot js groups

* build(deps-dev): bump the babel group with 5 updates

Bumps the babel group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) | `7.17.10` | `7.23.4` |
| [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) | `7.17.10` | `7.23.3` |
| [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) | `7.17.10` | `7.23.3` |
| [@babel/preset-react](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-react) | `7.16.7` | `7.23.3` |
| [babel-loader](https://github.com/babel/babel-loader) | `8.2.5` | `9.1.3` |

Updates `@babel/cli` from 7.17.10 to 7.23.4
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.4/packages/babel-cli)

Updates `@babel/core` from 7.17.10 to 7.23.3
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.3/packages/babel-core)

Updates `@babel/preset-env` from 7.17.10 to 7.23.3
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.3/packages/babel-preset-env)

Updates `@babel/preset-react` from 7.16.7 to 7.23.3
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.3/packages/babel-preset-react)

Updates `babel-loader` from 8.2.5 to 9.1.3
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](babel/babel-loader@v8.2.5...v9.1.3)

---
updated-dependencies:
- dependency-name: "@babel/cli"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: babel
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: babel
- dependency-name: "@babel/preset-env"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: babel
- dependency-name: "@babel/preset-react"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: babel
- dependency-name: babel-loader
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: babel
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): pin react-bootstrap

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Jochen Klar <mail@jochenklar.de>
Co-authored-by: David Wallace <david.wallace@tu-darmstadt.de>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jochenklar @leucoryx @YvanaGlasenapp