Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holiday Array output has incorrect day #14

Open
firefighterchuck opened this issue Dec 1, 2020 · 1 comment
Open

Holiday Array output has incorrect day #14

firefighterchuck opened this issue Dec 1, 2020 · 1 comment
Assignees
Labels
🙏 help wanted Extra attention is needed 🙅 worksforme This isn't reproducible by the maintainer

Comments

@firefighterchuck
Copy link

The Holiday Array output from this node has the wrong date in the date and the dateISOString values. In this example, the Holiday is entered as -21 days relative to the 4th Sunday in Advent. For 2020, the date should be 2020-11-29, and this shows correctly in the id, day, and natural month values, but not in the date and the dateISOString values:

Holiday Array output

This contrasts with the values in the payload.today object, which show correctly (screenshot was taken on 2020-12-01);
today

@Hypnos3 Hypnos3 self-assigned this Dec 23, 2020
@Hypnos3 Hypnos3 added 🙏 help wanted Extra attention is needed 🙅 worksforme This isn't reproducible by the maintainer labels Dec 23, 2020
@Hypnos3
Copy link
Collaborator

Hypnos3 commented Dec 23, 2020

The ISO string is in UTC time zone (There is a Z at the end, which means UTC).
The Day is calculated for the local time.

for the first pisture the rtimes are:
Your local time is: 11/29/2020 @ 5:00am (parameter ts is 1606626000)
Your UTC time is: 11/30/2020 @ 12:00am (parameter tsUTC is 1606694400)

So for the calculation the local time is used, where the day_id comes from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙏 help wanted Extra attention is needed 🙅 worksforme This isn't reproducible by the maintainer
Development

No branches or pull requests

2 participants