Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time inject issue #3

Closed
YorickErnst opened this issue Dec 7, 2018 · 6 comments
Closed

Time inject issue #3

YorickErnst opened this issue Dec 7, 2018 · 6 comments
Labels
🐛 bug Something isn't working

Comments

@YorickErnst
Copy link

Hi,

I've set up a time-inject to turn on my lights in the morning during working days. But it seems to trigger on Saturdays as well no matter which combination of days I select (Timestamp-based).

@Hypnos3 Hypnos3 added the 🐛 bug Something isn't working label Dec 7, 2018
@Hypnos3
Copy link
Collaborator

Hypnos3 commented Dec 9, 2018

I tried to reproduce the problem, but unfortunately I was not able to get the error.
Could you please provide me with more information?

Maybe could you please provide me the testcase?

@Hypnos3
Copy link
Collaborator

Hypnos3 commented Dec 9, 2018

When reviewing the code again, I noticed that the current day is determined as UTC timestamp.

If the time stamp is at midnight, erroneous results may occur. I have eliminated this problem with version 0.1.8.
Could you please test with this Version again?

@YorickErnst
Copy link
Author

Still no luck. Can the system locale have an impact? It is currently set to "nl_BE", but I didn't see any change with en_US when testing.

Here is the config
capture

[{"id":"391f3880.3a2938","type":"time-inject","z":"c1d56eac.9d2f3","name":"Alarm Clock","positionConfig":"51b4d50a.37addc","payload":"true","payloadType":"bool","topic":"A","time":"05:30","timeType":"entered","timeDays":"1","offset":0,"offsetMultiplier":60,"property":"","propertyType":"none","timeAlt":"","timeAltType":"entered","timeAltOffset":0,"timeAltOffsetMultiplier":60,"once":false,"onceDelay":0.1,"recalcTime":2,"x":450,"y":380,"wires":[["ef469c96.8634"]]},{"id":"51b4d50a.37addc","type":"position-config","z":0,"name":"Sun-Aalst","longitude":"4.041","latitude":"50.9378","angleType":"deg","timezoneOffset":"1"}]

@Hypnos3
Copy link
Collaborator

Hypnos3 commented Dec 10, 2018

Thank you, I will check!

@Hypnos3
Copy link
Collaborator

Hypnos3 commented Dec 10, 2018

The issue should be fixed with the latest version.

@YorickErnst
Copy link
Author

Dear,

It seems that it is indeed fixed now. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Development

No branches or pull requests

2 participants