Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *.css files to the list of sideEffect(ful) files #769

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

Andarist
Copy link
Contributor

This should resolve #761 (comment)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 92502c8:

Sandbox Source
reach-ui-template Configuration

@chaance
Copy link
Member

chaance commented Mar 29, 2021

I'm sure this is fine but I need to research a bit more for my own sake. I'll take care of this ASAP.

@chaance chaance added Status: Investigation Type: Bug Something isn't working labels Mar 29, 2021
@Andarist
Copy link
Contributor Author

sideEffects flag is actually an allowlist where if you use false as the value you are saying that no files have side-effects. You can use patterns to include files though and this pattern can be seen in the official webpack docs: https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free

@chaance chaance merged commit f0d70f5 into reach:develop Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Investigation Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants