Service worker not getting registered in localhost

[vaibhavarora14]

Description

For localhost, service worker is not getting registered

Steps to reproduce

It's easy to reproduce in all apps versioning 1.0.2 of this template.

Expected behavior
Service worker should get registered

Screenshots
Reason - For production it should work as per code. For localhost we are checking for service-worker.js file on window.origin. Which doesn't exist because there is no such file exposed in build folder when build is made.

I wish I could run other typescript templates and see the difference.

Versions

• react-boilerplate-cra-template: 1.0.2
• Node/NPM: 12.18.4/6.14.8
• Browser: Chrome 86.0.4240.111 (Official Build) (64-bit)

[Can-Sahin]

Did you register the service worker here =>

react-boilerplate-cra-template/src/index.tsx

Line 77 in 8068c36

serviceWorker.unregister();

[vaibhavarora14]

yes I did, that's how I am able to add captured screenshot of live debugging

[Can-Sahin]

I don't understand exactly. Can you do what you want with CRA and show me what output this boilerplate can't produce where in fact CRA can?

[vaibhavarora14]

https://github.com/varora1406/example-app

I have enabled service worker as you mentioned, you can run PWA test from google chrome devtools to verify that service worker isn't registered despite the code change you mentioned

Note: checkout latest commit of main branch

[vaibhavarora14]

Reason is mentioned in facebook/create-react-app#10032

[Can-Sahin]

I see. I honestly don't know :( It's been so long I didn't test offline-first functionality. In fact, I just removed it from this project because it's not easy to test and I cannot guarantee a working example

[vaibhavarora14]

i have fixed it in my app
I will submit a PR today here, don't worry