feat: add rootClassName #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heiyu4585
force-pushed
the
fix-rootClassName
branch
from
aa8e960 to
1b5cbab
Compare
heiyu4585
force-pushed
the
fix-rootClassName
branch
from
4ceb8f6 to
a670a00
Compare
zombieJ
reviewed
Apr 6, 2022
src/Menu.tsx
Outdated
| * | ||
| * - OpenTransitionName | ||
| * - OpenAnimation | ||
| * - OnDestroy |
There was a problem hiding this comment.
prettier自动转化的,也不转么
zombieJ
reviewed
Apr 6, 2022
| style="opacity: 0; pointer-events: none;" | ||
| > | ||
| <ul | ||
| class="rc-menu rc-menu-sub rc-menu-vertical custom-className" |
There was a problem hiding this comment.
rootClassName 总是出现在最外层 dom 上，这边出现两个是不对的。应该就在最外面的 div 上面。
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 25 25
Lines 674 674
Branches 175 175
=======================================
Hits 673 673
Misses 1 1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
heiyu4585
force-pushed
the
fix-rootClassName
branch
from
a670a00 to
7e3dda9
Compare
heiyu4585
force-pushed
the
fix-rootClassName
branch
from
7e3dda9 to
1b5cbab
Compare
|
@MadCcc pls help to release related minor version. |
|
v9.5.4 published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
ant-design/ant-design#34318
💡 Background and solution
📝 Changelog
rootClassNamerootClassName☑️ Self Check before Merge