-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add onKeyDown Props that supports prevent default behavior #138
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/picker/3l02bvuep |
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 45 45
Lines 2033 2044 +11
Branches 600 601 +1
=======================================
+ Hits 2025 2036 +11
Misses 6 6
Partials 2 2
Continue to review full report at Codecov.
|
pull from master repository 09/09/2020
update readme update basic example
update branch
fix preventDefaultBehaviors types
Would really like to see this merge, it would definitely help to setup alternative picker behaviors. |
Please tell me when this pull request will be merged? |
@conquera99 can you resolve conflicts? |
okay, i will try to resolve the conflicts tonight |
update examples add test case for prevent default apply @kerm1it suggestions
just applied your suggestions, please review it again thank you @kerm1it |
rename all preventDefaultBehaviors to preventDefault apply @kerm1it suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@afc163 这个我看没有问题了,可以合了。 |
This comment has been minimized.
This comment has been minimized.
哪里还有呢?没找到😂 |
没注意看 diff,我看标题和描述里还有。 |
代码里面应该没有了,描述里面确实还有,还没有改。 |
fix ant-design/ant-design#26279
fix #40
changes:
preventDefault
in second args to prevent default behavior