fix: fix picker in shadowdom #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/picker/eycw5qt8l |
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
- Coverage 99.61% 99.57% -0.05%
==========================================
Files 45 45
Lines 2094 2101 +7
Branches 616 617 +1
==========================================
+ Hits 2086 2092 +6
- Misses 6 7 +1
Partials 2 2
Continue to review full report at Codecov.
|
afc163
reviewed
Feb 7, 2021
| preventBlurRef.current = true; | ||
|
|
||
| // Always set back in case `onBlur` prevented by user | ||
| requestAnimationFrame(() => { | ||
| preventBlurRef.current = false; | ||
| }); | ||
| } else if (!focused) { | ||
| } else if (!focused || clickedOutside) { |
There was a problem hiding this comment.
这个没有意义吧，else if 时 clickedOutside 一定是 true 的。
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix event.target if event triggered in shadow dom