-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove useless #48
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 98.44% 99.21% +0.76%
==========================================
Files 2 2
Lines 129 127 -2
Branches 30 29 -1
==========================================
- Hits 127 126 -1
+ Misses 2 1 -1 ☔ View full report in Codecov by Sentry. |
为啥删掉这个? |
有点久忘了。。。现在看起来这块逻辑跟InternalSegmentedOption内部的change事件有重复,实际上是多余的,会导致单测覆盖不到这块逻辑 |
@vagusX 看看这个 |
Walkthrough此次更改涉及移除 Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files not reviewed due to no reviewable changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit
Segmented
组件中onChange
事件处理程序的disabled
状态检查,允许在禁用状态下仍能执行相关操作。