Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushable feature inaccuracy #199

Closed
tasiek opened this issue Jan 4, 2017 · 5 comments
Closed

Pushable feature inaccuracy #199

tasiek opened this issue Jan 4, 2017 · 5 comments

Comments

@tasiek
Copy link

tasiek commented Jan 4, 2017

There's an inaccuracy issue with pushable feature, when dragged through the "edge" of range.
After reaching the end, the final value is calculated incorrectly in some cases - it stops the handler too early.

rc-slider-range-pushable-issue

In this case, pushable's range is set to 250.

@benjycui
Copy link
Member

It will be better if you can provide steps which can re-produce it every time.

@Robin-front
Copy link
Contributor

I think the reason is mousemove event is not continued.
move

sometimes, the handle value will sudden skip to 1000 from 740.
But when pushing is impossible. the author reset the handle value to originalValue. That's why pushable feature inaccuracy. The logic look here

So, I think reset the handle value to limit is better, rather than originalValue.
bounds[handle] = bounds[nextHandle] - (direction * threshold);

@paranoidjk
Copy link
Member

@Robin-front Sounds reasonable,could you give a reproducible demo? or add some test case in your PR? Thanks.

@Robin-front
Copy link
Contributor

@paranoidjk okay, I will try. :)

@yesmeck yesmeck closed this as completed Mar 7, 2018
@yesmeck
Copy link
Member

yesmeck commented Mar 7, 2018

Fixed in 8.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants