Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to react 16 already on master, can a tag please be cut and published? #333

Closed
caguthrie opened this issue Oct 11, 2017 · 3 comments

Comments

@caguthrie
Copy link
Contributor

Would love to use this with React 16 in my project. Thanks

@benjycui
Copy link
Member

Just upgrade react in your project, we don't need to publish new version of rc-slider.

@caguthrie
Copy link
Contributor Author

caguthrie commented Oct 17, 2017

With react@16, dependency rc-tooltip@3.4.2 is incompatible as it uses React.PropTypes. While "rc-tooltip": "^3.4.2" is listed in package.json which should resolve to a good version normally with the ^, if a user is using a yarn.lock, package.lock, or similar lockfile with rc-tooltip@3.4.2, nothing will appear wrong when dependencies are resolved. If you want to reopen this ticket I'm happy to raise a PR to change this to "rc-tooltip": "^3.4.3", the first version to no longer use React.PropTypes.

@benjycui
Copy link
Member

If you want to reopen this ticket I'm happy to raise a PR to change this to "rc-tooltip": "^3.4.3", the first version to no longer use React.PropTypes.

OK, just PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants