Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why React is not a peerDependency? #589

Open
viniciusbo opened this issue Aug 26, 2019 · 0 comments
Open

Why React is not a peerDependency? #589

viniciusbo opened this issue Aug 26, 2019 · 0 comments

Comments

@viniciusbo
Copy link

viniciusbo commented Aug 26, 2019

Hi! I ran into some weird errors since the inclusion of rc-slider in one of my libs due to duplicated copies of React being loaded.

Since my use case needs React lib as an external dependency in webpack config, I was wondering why React is not loaded as a peerDependency in rc-slider's package.json instead? Actually the same is true for rc-tooltip lib. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant