fix: quotes in key crashes

react-component · Mar 9, 2023 · 8f9b2e5 · 8f9b2e5
1 parent a00181f
commit 8f9b2e5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/util.ts b/src/util.ts
@@ -1,3 +1,5 @@
+import React from 'react';
+
 /**
  * We trade Map as deps which may change with same value but different ref object.
  * We should make it as hash for deps
@@ -18,6 +20,6 @@ export function stringify<K extends string | number | symbol, V>(obj: Record<K,
 }
 
 const RC_TABS_DOUBLE_QUOTE = 'TABS_DQ';
-export function genDataNodeKey(key: string): string {
-  return key.replace(/"/g, RC_TABS_DOUBLE_QUOTE);
+export function genDataNodeKey(key: React.Key): string {
+  return String(key).replace(/"/g, RC_TABS_DOUBLE_QUOTE);
 }
diff --git a/tests/index.test.tsx b/tests/index.test.tsx
@@ -513,5 +513,9 @@ describe('Tabs.Basic', () => {
 
   it('key contains double quote should not crash', () => {
     render(<Tabs items={[{key: '"key"', label: 'test'}]} />)
+  });
+
+  it('key could be number', () => {
+    render(<Tabs items={[{key: 1 as any, label: 'test'}]} />)
   })
 });