Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add overflow trigger props #706

Merged
merged 8 commits into from
Apr 5, 2024
Merged

feat: add overflow trigger props #706

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b1665cf
feat: add overflow trigger props
CooperHash Mar 27, 2024
725236d
combine moreTrigger and moreIcon to more props
CooperHash Mar 27, 2024
cc18fce
Optimization Type
CooperHash Mar 27, 2024
ee2f480
add dropdownprops with omit children
CooperHash Mar 28, 2024
21d2092
merge moreTransitio to more
CooperHash Mar 29, 2024
5c64a52
fix
CooperHash Mar 29, 2024
e5284fe
fix
CooperHash Mar 29, 2024
25c8541
remove moreTransition
CooperHash Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/TabNavList/OperationNode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ export interface OperationNodeProps {
activeKey: string;
mobile: boolean;
more?: MoreProps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
more?: MoreProps
more?: MoreProps;

moreTransitionName?: string;
editable?: EditableConfig;
locale?: TabsLocale;
removeAriaLabel?: string;
Expand All @@ -37,7 +36,6 @@ const OperationNode = React.forwardRef<HTMLDivElement, OperationNodeProps>((prop
locale,
mobile,
more: moreProps = {},
moreTransitionName,
style,
className,
editable,
Expand Down Expand Up @@ -193,7 +191,6 @@ const OperationNode = React.forwardRef<HTMLDivElement, OperationNodeProps>((prop
prefixCls={dropdownPrefix}
overlay={menu}
visible={tabs.length ? open : false}
transitionName={moreTransitionName}
onVisibleChange={setOpen}
overlayClassName={classNames(overlayClassName, popupClassName)}
mouseEnterDelay={0.1}
Expand Down
1 change: 1 addition & 0 deletions src/interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export type TriggerProps = {
export type moreIcon = React.ReactNode;
export type MoreProps = {
icon?: moreIcon,
transitionName?: string,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DropdownProps 应该有 transitionName ？

} & Omit<DropdownProps, 'children'>;

export type SizeInfo = [width: number, height: number];
Expand Down
Loading