Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prop-types and create-react-class warning #67

Merged
merged 3 commits into from
May 1, 2017
Merged

Fix prop-types and create-react-class warning #67

merged 3 commits into from
May 1, 2017

Conversation

ddcat1115
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Coverage increased (+1.9%) to 31.28% when pulling 20990c1 on ddcat1115:React15.5.0 into f21d45b on react-component:master.

@benjycui benjycui requested a review from shepherdwind April 19, 2017 07:41
@coveralls
Copy link

Coverage Status

Coverage increased (+2.1%) to 31.496% when pulling 50c397e on ddcat1115:React15.5.0 into f21d45b on react-component:master.

@afc163
Copy link
Member

afc163 commented Apr 30, 2017

@shepherdwind

@afc163 afc163 mentioned this pull request Apr 30, 2017
Closed
shepherdwind
shepherdwind reviewed Apr 30, 2017
View reviewed changes
Copy link
Contributor

@shepherdwind shepherdwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createClass 最好改下

src/AjaxUploader.jsx Outdated
import classNames from 'classnames';
import defaultRequest from './request';
import getUid from './uid';

const AjaxUploader = React.createClass({
const AjaxUploader = createReactClass({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要用 createReactClass 了吧

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里改成 class 的？

src/IframeUploader.jsx Outdated
@@ -14,7 +16,8 @@ const IFRAME_STYLE = {
};

// diferent from AjaxUpload, can only upload on at one time, serial seriously
const IframeUploader = React.createClass({
const IframeUploader = createReactClass({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有这里

package.json Outdated
@@ -52,6 +52,8 @@
"dependencies": {
"babel-runtime": "6.x",
"classnames": "^2.2.5",
"warning": "2.x"
"warning": "2.x",
"create-react-class": "^15.5.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个依赖不需要吧

@coveralls
Copy link

Coverage Status

Coverage increased (+7.4%) to 36.758% when pulling 08f5fbc on ddcat1115:React15.5.0 into f21d45b on react-component:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+7.4%) to 36.758% when pulling 08f5fbc on ddcat1115:React15.5.0 into f21d45b on react-component:master.

@shepherdwind shepherdwind merged commit ce4fa45 into react-component:master May 1, 2017
@shepherdwind
Copy link
Contributor

2.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shepherdwind shepherdwind shepherdwind left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddcat1115 @coveralls @afc163 @shepherdwind