Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve useResizeObserver #168

Merged
merged 1 commit into from
Jul 3, 2021
Merged

feat: improve useResizeObserver #168

merged 1 commit into from
Jul 3, 2021

Conversation

xobotyi
Copy link
Contributor

@xobotyi xobotyi commented Jun 30, 2021

What new hook does?

Now listeners invoked asynchronously so none of them waiting other's invocation.

Checklist

  • Have you read contribution guideline?
  • Does the code have comments in hard-to-understand areas?
  • Is there an existing issue for this PR?
    • link issue here
  • Have the files been linted and formatted?
  • Have the docs been updated?
  • Have the tests been added to cover new hook?
  • Have you run the tests locally to confirm they pass?

@xobotyi xobotyi added the ✨ enhancement New feature or request label Jun 30, 2021
@xobotyi xobotyi requested a review from JoeDuncko June 30, 2021 20:54
@codecov
Copy link

codecov bot commented Jun 30, 2021 •
edited
Loading

Codecov Report

Merging #168 (26c7751) into master (a0df12c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #168   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        41           
  Lines          670       671    +1     
  Branches       114       114           
=========================================
+ Hits           670       671    +1
Impacted Files Coverage Δ
src/useResizeObserver/useResizeObserver.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0df12c...26c7751. Read the comment docs.

@xobotyi
feat: improve useResizeObserver
26c7751 
Now listeners invoked asynchronously so none of them waiting other's
invocation
JoeDuncko
JoeDuncko approved these changes Jul 3, 2021
View reviewed changes
Copy link
Contributor

@JoeDuncko JoeDuncko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoeDuncko JoeDuncko merged commit f6fa33a into master Jul 3, 2021
github-actions bot pushed a commit that referenced this pull request Jul 3, 2021
@semantic-release-bot
chore(release): 3.6.0 [skip ci]
731a194 
# [3.6.0](v3.5.0...v3.6.0) (2021-07-03)

### Features

* improve `useResizeObserver` ([#168](#168)) ([f6fa33a](f6fa33a))
@xobotyi
Copy link
Contributor Author

xobotyi commented Jul 3, 2021

🎉 This PR is included in version 3.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xobotyi xobotyi deleted the improve-usResizeObserver branch July 20, 2021 14:40
@xobotyi xobotyi restored the improve-usResizeObserver branch July 20, 2021 14:41
@xobotyi xobotyi deleted the improve-usResizeObserver branch July 20, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeDuncko JoeDuncko JoeDuncko approved these changes

Assignees
No one assigned
Labels
✨ enhancement New feature or request released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xobotyi @JoeDuncko