Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new hook useIntersectionObserver #170

Merged
merged 4 commits into from
Jul 3, 2021
Merged

feat: new hook useIntersectionObserver #170

merged 4 commits into from
Jul 3, 2021

Conversation

xobotyi
Copy link
Contributor

@xobotyi xobotyi commented Jun 30, 2021 •
edited
Loading

What new hook does?

Tracks intersection of a target element with an ancestor element or with a top-level document's viewport.

Checklist

  • Have you read contribution guideline?
  • Does the code have comments in hard-to-understand areas?
  • Is there an existing issue for this PR?
  • Have the files been linted and formatted?
  • Have the docs been updated?
  • Have the tests been added to cover new hook?
  • Have you run the tests locally to confirm they pass?

@xobotyi xobotyi added the 🎂 new hook New hook added label Jun 30, 2021
@xobotyi xobotyi requested a review from JoeDuncko June 30, 2021 21:41
@codecov
Copy link

codecov bot commented Jun 30, 2021 •
edited
Loading

Codecov Report

Merging #170 (5742cd4) into master (a0df12c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #170   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        42    +1     
  Lines          670       729   +59     
  Branches       114       128   +14     
=========================================
+ Hits           670       729   +59
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
...useIntersectionObserver/useIntersectionObserver.ts 100.00% <100.00%> (ø)
src/useEventListener/useEventListener.ts 100.00% <0.00%> (ø)
src/useResizeObserver/useResizeObserver.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0df12c...5742cd4. Read the comment docs.

@xobotyi xobotyi force-pushed the use_intersection_observer branch 3 times, most recently from 2239ce1 to 82ca4dc Compare July 1, 2021 19:21
@xobotyi xobotyi marked this pull request as ready for review July 1, 2021 19:21
@xobotyi xobotyi force-pushed the use_intersection_observer branch from 82ca4dc to d8e0758 Compare July 1, 2021 19:24
@JoeDuncko JoeDuncko merged commit e97c163 into master Jul 3, 2021
github-actions bot pushed a commit that referenced this pull request Jul 3, 2021
@semantic-release-bot
chore(release): 3.8.0 [skip ci]
ec49655 
# [3.8.0](v3.7.0...v3.8.0) (2021-07-03)

### Features

* new hook useIntersectionObserver ([#170](#170)) ([e97c163](e97c163))
@xobotyi
Copy link
Contributor Author

xobotyi commented Jul 3, 2021

🎉 This PR is included in version 3.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xobotyi xobotyi deleted the use_intersection_observer branch July 20, 2021 14:40
@xobotyi xobotyi restored the use_intersection_observer branch July 20, 2021 14:40
@xobotyi xobotyi deleted the use_intersection_observer branch July 20, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeDuncko JoeDuncko Awaiting requested review from JoeDuncko

Assignees
No one assigned
Labels
🎂 new hook New hook added released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xobotyi @JoeDuncko