feat: remove cjs support and raise language level to ESNext #963

wesgro · 2022-10-12T16:09:18Z

BREAKING CHANGE

All evergreen browsers fully support the ES6 spec (Even Safari as of Safari 10)

Generating ES5 compliant code introduces unnecessary language polyfills that can bloat bundles and possibly create warnings in rollup (no top level this for example).

Since this library supports React 18 and React 18 no longer supports IE 11 this seems like a good time to raise the floor of the non-ESNext generated code.

If users of this library need to support IE 11 still they can always include this library in their babel config to transpile it down to whatever ES version they need to support.

Fixes #962

ArttuOll · 2022-10-14T16:10:58Z

I find your reasoning to be sound. ES6 indeed is massively supported.

The only thing that worries me is this statement from the browserlist repo:

Don’t remove browsers just because you don’t know them. Opera Mini has 100 million users in Africa and it is more popular in the global market than Microsoft Edge.

I was able to confirm the 100 million users from the Opera Mini site.

It happens to be the case that Opera Mini does not support ES6. If this change was made, all the developers developing for those 100 million users in Africa would have to transpile this library.

This is all just food for thought. In my opinion, this change would be good. Opera Mini should catch up and add support for ES6. I also checked a bunch of popular React libraries and frameworks (such as react-query and NextJS) and their TypeScript targets also seem to be either es6 or esnext.

What do you think @xobotyi?

xobotyi · 2022-10-15T11:17:09Z

I dont have a decision tbh.
As for my projects i transpile node_modules anyway, since i have to maintain compatibility with console browsers (which is complete mess tbh).

Im not able to imagine how many users pipelines that change would break.
I'd consider hanging it for a while, untill we'll clear all current issues and then make a major version with lang-level upgrade

wesgro · 2022-10-15T14:23:19Z

Im not able to imagine how many users pipelines that change would break.

Would you be open to only the esm path using es6? ESM would only be in use by browsers that have es6 support already. the cjs path could remain in es5 form.

JoeDuncko · 2022-10-22T20:21:51Z

Im not able to imagine how many users pipelines that change would break.

Would you be open to only the esm path using es6? ESM would only be in use by browsers that have es6 support already. the cjs path could remain in es5 form.

This sounds like a reasonable compromise to me. Anyone else?

ArttuOll · 2022-10-23T13:13:00Z

Would you be open to only the esm path using es6? ESM would only be in use by browsers that have es6 support already. the cjs path could remain in es5 form.

Sounds like a really reasonable compromise to me as well.

xobotyi · 2022-10-23T21:43:21Z

I've reduced esnext version to module.
This patch will go as major version as it breaks backwards compatibility. (but is highly doubdt that someone used esnext version =))

It will be slow step forward to fix of #659 and switching to type: "module"

wesgro · 2022-11-10T23:28:21Z

I see a few breaking changes have gone through, is there a plan for this to get in soon?

xobotyi · 2022-11-10T23:38:27Z

Yes, as soon as we figure current backlog

xobotyi · 2022-11-10T23:39:45Z

*current backlog before this pr

ArttuOll · 2022-12-03T14:00:24Z

Yes, as soon as we figure current backlog

@xobotyi On our issues list there's currently pretty much nothing in addition to this that we would need to act on. There's open PR's but I don't think any of them are ready to be merged in a while, except for the documentation PRs. Would now be the time to tackle this PR?

xobotyi · 2022-12-04T19:09:33Z

yup - i've planned to handle it on tuesday

xobotyi · 2023-01-02T10:12:40Z

Im thinking of making one more step further and leave only one version - esm, with esnext langlevel.

A bit harsh move, but we'll have make it anyway as we will have to move to module package once infrastructure will be ready. All major bundlers handles module dependencies perfectly.

I'll update this pr now, and leave it here for a couple of days. planned date of merge is 4th Jan.

@wesgro @ArttuOll @JoeDuncko

xobotyi · 2023-01-02T13:48:29Z

the only downsite - had to temporarily disable built bundle testing due to issue with jest: jestjs/jest#13715

wesgro · 2023-01-02T17:54:55Z

@xobotyi Would it be possible to retain cjs support? Although many modern bundlers have support there are probably a tonne of legacy bundlers still in use that would need a CJS path (I say greedily, as I have to deal with one of them 😜 )

xobotyi · 2023-01-02T17:56:47Z

Which one? 🤔

wesgro · 2023-01-02T18:00:41Z

I believe we still have something using webpack 3 and requires us to ship CJS or they can't use our library. They're a different team from us so them changing their build for our teams' needs probably isn't something that will get on their road map any time soon.

Not the end of the world since I could opt to bundle this code when we ship CJS, but not completely ideal either.

xobotyi · 2023-01-02T21:04:45Z

But you have to transpile node_modules anyway, since many tools coming esm only🤔

As for me - I'd cut everything in one move, since it will ease further support and future moving to type: module

wesgro · 2023-01-02T21:18:53Z

Sounds good 👍 I don’t want to be in the way of progress

…

On Mon, Jan 2, 2023 at 1:04 PM Anton Zinovyev ***@***.***> wrote: But you have to transpile node_modules anyway, since many tools coming esm only🤔 As for me - I'd cut everything in one move, since it will ease further support and future moving to type: module — Reply to this email directly, view it on GitHub <#963 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAERM35A77FZRKW4JM4GN33WQM7HPANCNFSM6AAAAAARDOECNI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

BREAKING CHANGE All evergreen browsers fully support the ES6 spec (Even Safari as of Safari 10) Generating ES5 compliant code introduces unnecessary language polyfills that can bloat bundles and possibly create warnings in rollup (no top level this for example). Since this library supports React 18 and React 18 no longer supports IE 11 this seems like a good time to raise the floor of the non-ESNext generated code. If users of this library need to support IE 11 still they can always include this library in their babel config to transpile it down to whatever ES version they need to support.

BREAKING CHANGE: remove esnext version, now esmodules serves es esnext version.

Make use of SWC - it drastically improves tests performance. Bundle build still performed with ts though.

BREAKING CHANGE: `CJS ES5` and `ESM ES5` versions are removed from distribution, leaving only `ESM ESNext` version. We understand that this change can break existing pipelines for some developers, but such move eases library maintenance and is one of several moves towards module package. This change is one of several braking changes that will be released under same major version regarding changes in distribution and importing. Sorry for any inconvenience.

# [21.0.0](v20.1.0...v21.0.0) (2023-01-04) ### Features * **no-release:** drop es5 versions support, leave only ESNext ([#963](#963)) ([5a622af](5a622af)) ### BREAKING CHANGES * **no-release:** `CJS ES5` and `ESM ES5` versions are removed from distribution, leaving only `ESM ESNext` version. We understand that this change can break existing pipelines for some developers, but such move eases library maintenance and is one of several moves towards module package. This change is one of several braking changes that will be released under same major version regarding changes in distribution and importing. Sorry for any inconvenience.

xobotyi · 2023-01-05T13:42:14Z

@wesgro in closest release CJS version will be returned🙃

wesgro · 2023-01-05T15:41:10Z

Moving fast and breaking things!

…

On Thu, Jan 5, 2023 at 5:42 AM Anton Zinovyev ***@***.***> wrote: @wesgro <https://github.com/wesgro> in closest release CJS version will be returned🙃 — Reply to this email directly, view it on GitHub <#963 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAERM34COTIZ2LHO2XZXCODWQ3FUBANCNFSM6AAAAAARDOECNI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

xobotyi added the postponed label Oct 18, 2022

xobotyi force-pushed the pr/962 branch from 57d51f5 to d11435d Compare January 2, 2023 10:15

xobotyi changed the title ~~feat!: raises the target floor for compiled Javascript to ES6~~ feat: remove cjs support and raise language level to ESNext Jan 2, 2023

xobotyi mentioned this pull request Jan 2, 2023

[Bug]: transformers not applied to mapped modules jestjs/jest#13715

Closed

wesgro and others added 7 commits January 4, 2023 12:53

feat: replace esmodules with esnext verson

352fcbd

BREAKING CHANGE: remove esnext version, now esmodules serves es esnext version.

chore: get rid of cjs version, update test runners to node 18

f305c60

fix: proper build script

1a19a77

fix: reconfigure tests to work with new build target

dea5fb3

Make use of SWC - it drastically improves tests performance. Bundle build still performed with ts though.

fix: disable built bundle testing due to jest bug

5d10888

docs: fix docs and annotate changes in distributed bundle

758b37d

xobotyi force-pushed the pr/962 branch from 6d07187 to 758b37d Compare January 4, 2023 11:53

style: fix lint issue

bfe233c

xobotyi merged commit 477853a into react-hookz:master Jan 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: remove cjs support and raise language level to ESNext #963

feat: remove cjs support and raise language level to ESNext #963

wesgro commented Oct 12, 2022

ArttuOll commented Oct 14, 2022 •

edited

Loading

xobotyi commented Oct 15, 2022

wesgro commented Oct 15, 2022 •

edited

Loading

JoeDuncko commented Oct 22, 2022

ArttuOll commented Oct 23, 2022

xobotyi commented Oct 23, 2022 •

edited

Loading

wesgro commented Nov 10, 2022

xobotyi commented Nov 10, 2022 •

edited

Loading

xobotyi commented Nov 10, 2022

ArttuOll commented Dec 3, 2022

xobotyi commented Dec 4, 2022

xobotyi commented Jan 2, 2023 •

edited

Loading

xobotyi commented Jan 2, 2023 •

edited

Loading

wesgro commented Jan 2, 2023

xobotyi commented Jan 2, 2023

wesgro commented Jan 2, 2023

xobotyi commented Jan 2, 2023

wesgro commented Jan 2, 2023 via email

xobotyi commented Jan 5, 2023

wesgro commented Jan 5, 2023 via email

feat: remove cjs support and raise language level to ESNext #963

feat: remove cjs support and raise language level to ESNext #963

Conversation

wesgro commented Oct 12, 2022

ArttuOll commented Oct 14, 2022 • edited Loading

xobotyi commented Oct 15, 2022

wesgro commented Oct 15, 2022 • edited Loading

JoeDuncko commented Oct 22, 2022

ArttuOll commented Oct 23, 2022

xobotyi commented Oct 23, 2022 • edited Loading

wesgro commented Nov 10, 2022

xobotyi commented Nov 10, 2022 • edited Loading

xobotyi commented Nov 10, 2022

ArttuOll commented Dec 3, 2022

xobotyi commented Dec 4, 2022

xobotyi commented Jan 2, 2023 • edited Loading

xobotyi commented Jan 2, 2023 • edited Loading

wesgro commented Jan 2, 2023

xobotyi commented Jan 2, 2023

wesgro commented Jan 2, 2023

xobotyi commented Jan 2, 2023

wesgro commented Jan 2, 2023 via email

xobotyi commented Jan 5, 2023

wesgro commented Jan 5, 2023 via email

ArttuOll commented Oct 14, 2022 •

edited

Loading

wesgro commented Oct 15, 2022 •

edited

Loading

xobotyi commented Oct 23, 2022 •

edited

Loading

xobotyi commented Nov 10, 2022 •

edited

Loading

xobotyi commented Jan 2, 2023 •

edited

Loading

xobotyi commented Jan 2, 2023 •

edited

Loading