Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to recreate IOS/Android folders #1070

Closed
wtrocki opened this issue Mar 25, 2020 · 4 comments
Closed

Ability to recreate IOS/Android folders #1070

wtrocki opened this issue Mar 25, 2020 · 4 comments

Comments

@wtrocki
Copy link
Contributor

wtrocki commented Mar 25, 2020

Describe the Feature

When creating react-native projects IOS and Android folders are created with native code. Since auto-linking is now enabled in situations where there will be no changes in this native codebase is there any justification to commit them to the repository?

Would it be possible to dynamically recreate IOS and Android folders with content without calling init and copying pasting code?

@wtrocki
Copy link
Contributor Author

wtrocki commented Mar 25, 2020

Typical approach with using react-native upgrade is not regenerating the ios and android folders.

@thymikee
Copy link
Member

is there any justification to commit them to the repository?

Yes, otherwise you wouldn't easily be able to run projects from native IDEs, since these would live in node_modules and could get erased any time.

Would it be possible to dynamically recreate IOS and Android folders with content without calling init and copying pasting code?

This is a question that comes back once in a while, e.g. here: #503. I don't really see such command being less of a hack than init and replacing. It's a very rare use-case.

I'm open to a discussion on how we could simplify handling native projects, but I believe https://github.com/react-native-community/discussions-and-proposals is a better place to do so.

@thymikee
Copy link
Member

Typical approach with using react-native upgrade is not regenerating the ios and android folders

Why would it? It's not advertised to do so.

@wtrocki
Copy link
Contributor Author

wtrocki commented Mar 25, 2020

This is a question that comes back once in a while, e.g. here: #503. I don't really see such command being less of a hack than init and replacing. It's a very rare use-case.

Ok. This is great clarification and I'm fully aware that this is the rare use case. Thank you for coming back so fast with an explanation! Closing as we both agreed that there is nothing to action here.

@wtrocki wtrocki closed this as completed Mar 25, 2020
@wtrocki wtrocki reopened this Mar 25, 2020
@wtrocki wtrocki closed this as completed Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants