Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open developer menu" command doesn't work from the terminal for iOS and RNW #1213

Closed
RedMickey opened this issue Jul 2, 2020 · 12 comments
Closed
Assignees
Labels
bug report no-stale-bot This issue cannot be marked as stale by stale bot

Comments

@RedMickey
Copy link

Environment

  • MacOS:
    System:
    OS: macOS 10.15.5
    CPU: (6) x64 Intel(R) Core(TM) i5-8500B CPU @ 3.00GHz
    Memory: 1.11 GB / 32.00 GB
    Shell: 5.7.1 - /bin/zsh
    Binaries:
    Node: 10.19.0 - ~/.nvm/versions/node/v10.19.0/bin/node
    Yarn: 1.22.0 - /usr/local/bin/yarn
    npm: 6.13.4 - ~/.nvm/versions/node/v10.19.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
    Managers:
    CocoaPods: 1.8.3 - /usr/local/bin/pod
    SDKs:
    iOS SDK:
    Platforms: iOS 13.5, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK:
    API Levels: 25, 27, 28, 29
    Build Tools: 23.0.1, 25.0.1, 25.0.2, 27.0.3, 28.0.3, 29.0.0, 29.0.1
    System Images: android-28 | Google APIs Intel x86 Atom, android-29 | Google APIs Intel x86 Atom
    Android NDK: Not Found
    IDEs:
    Android Studio: 3.6 AI-192.7142.36.36.6241897
    Xcode: 11.5/11E608c - /usr/bin/xcodebuild
    Languages:
    Java: 1.8.0_222 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
    npmPackages:
    @react-native-community/cli: Not Found
    react: 16.11.0 => 16.11.0
    react-native: 0.62.2 => 0.62.2
    npmGlobalPackages:
    react-native: Not Found

  • Windows
    System:
    OS: Windows 10 10.0.18362
    CPU: (8) x64 Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
    Memory: 7.62 GB / 15.94 GB
    Binaries:
    Node: 12.14.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.17.3 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.13.4 - C:\Program Files\nodejs\npm.CMD
    Watchman: Not Found
    SDKs:
    Android SDK:
    API Levels: 27, 28, 29
    Build Tools: 27.0.3, 28.0.2, 28.0.3, 29.0.2, 29.0.3
    System Images: android-28 | Google APIs Intel x86 Atom, android-29 | Google APIs Intel x86 Atom
    Android NDK: Not Found
    IDEs:
    Android Studio: Version 3.6.0.0 AI-192.7142.36.36.6241897
    Languages:
    Java: 1.8.0_212-release - C:\Program Files\Android\Android Studio\jre\bin\javac.EXE
    Python: 3.7.6 - C:\Python37\python.EXE
    npmPackages:
    @react-native-community/cli: Not Found
    react: 16.11.0 => 16.11.0
    react-native: ^0.62.0-0 => 0.62.2
    npmGlobalPackages:
    react-native: Not Found

Description

Please see the original issue.

I created a plain React Native v0.62.2 project.
I tried to open dev menu on an iOS simulator from the terminal by pressing "d", but it didn't open. At the same time the Reload command works fine.

image

I also faced the same problem on a React Native Windows application.
It seems that "Open developer menu" command works incorrectly from the terminal.

@RedMickey
Copy link
Author

Hi, are there any updates on this?

@alpha0010
Copy link

Definitely annoying. My workaround for iOS was to use AssistiveTouch to put a button on screen that triggers the shake gesture. Frequently shaking a device during development is not good (difficult for tablets, and damaging to cables/ports).

@EzioLi01
Copy link

EzioLi01 commented Aug 1, 2022

This issue is still repro. Could you please help on this?

@github-actions
Copy link

There hasn't been any activity on this issue in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

@github-actions github-actions bot added the stale label Nov 27, 2022
@TMisiukiewicz
Copy link
Collaborator

to be checked again with newer version of RN

@adamTrz
Copy link
Collaborator

adamTrz commented Nov 28, 2022

Can confirm that issue is still present

@adamTrz adamTrz removed the stale label Nov 28, 2022
@TMisiukiewicz
Copy link
Collaborator

@adamTrz I tried to investigate that, but cannot find where exactly the websocket messages are received - do you have any knowledge about it? Reloading the app works as excepted

@TMisiukiewicz TMisiukiewicz added the no-stale-bot This issue cannot be marked as stale by stale bot label Dec 6, 2022
@adamTrz
Copy link
Collaborator

adamTrz commented Dec 9, 2022

Well, the message is definitely being sent here:

otherWs.send(JSON.stringify(forwarded));

but then somehow it's got lost 🤷

@TMisiukiewicz
Copy link
Collaborator

seems to work correctly on Android 🤷 any help with discovering what's going on there is highly appreciated

@EzioLi01
Copy link

EzioLi01 commented Feb 1, 2023

Checking it still repro on 0.71.1.

@TMisiukiewicz
Copy link
Collaborator

@szymonrybczak assigning you to remember closing it once your PR is merged. Awesome job 👏

@szymonrybczak
Copy link
Collaborator

Closing since it's done by facebook/react-native#36115 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report no-stale-bot This issue cannot be marked as stale by stale bot
Projects
None yet
Development

No branches or pull requests

6 participants