Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Available Apple Devices #1673

Closed
esthor opened this issue Aug 11, 2022 · 6 comments
Closed

List Available Apple Devices #1673

esthor opened this issue Aug 11, 2022 · 6 comments
Labels
feature request no-stale-bot This issue cannot be marked as stale by stale bot

Comments

@esthor
Copy link
Contributor

esthor commented Aug 11, 2022

Describe the Feature

Instead of passing the --simulator "{some apple device simulator string}" I would like an interactive option to first list the available simulators and select the one I want.

Possible Implementations

  1. add a list command of --list flag to run-ios command
  2. Reuse available device listing & parsing logic in findMatchingSimulator.ts to print the devices to the console
  3. User can use arrows to select the device
  4. The selected devices is passed to a react-native run-ios --simulator "{selected apple device simulator name}" command

Related Issues

Not in this repo, but a very popular tool called ohmyzsh has a plugin for react-native, and to be up-to-date it is manually updated with device simulator flags. I think this main benefit of this aliasing plugin would be surpassed by an interactive list available devices function in the CLI itself.

For those not using the above ohmyzsh plugin, having this part of the CLI itself would be easier and clearer, and users wouldn't need to open up xCode to see available simulators or run xcrun simctl list devices either.

I'm happy to work on it, but wanted to know first if it would be well-received or not. 🙏

@thymikee
Copy link
Member

Sounds like something useful, happy to review PR :)

@esthor
Copy link
Contributor Author

esthor commented Aug 11, 2022

Awesome, @thymikee. Thanks.

Do you know of any interactive cli functionality already in the repo? I didn't find anything in a quick glance. I want to make sure I don't introduce some new pattern if there already is an established one.

@thymikee
Copy link
Member

Doctor command has some, you can check that

@esthor
Copy link
Contributor Author

esthor commented Aug 12, 2022

Thanks! I also found an unrelated bug while working on this, and put up a PR: #1675

@github-actions
Copy link

There hasn't been any activity on this issue in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

@github-actions github-actions bot added the stale label Nov 24, 2022
@adamTrz adamTrz removed the stale label Nov 24, 2022
@TMisiukiewicz TMisiukiewicz added the no-stale-bot This issue cannot be marked as stale by stale bot label Dec 6, 2022
@szymonrybczak
Copy link
Collaborator

Closing since it's done by #1676.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request no-stale-bot This issue cannot be marked as stale by stale bot
Projects
None yet
Development

No branches or pull requests

5 participants