Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autolink failed to get react-native-code-push deployment key #434

Closed
robertying opened this issue Jun 20, 2019 · 4 comments · Fixed by #435
Closed

Autolink failed to get react-native-code-push deployment key #434

robertying opened this issue Jun 20, 2019 · 4 comments · Fixed by #435
Labels
bug Something isn't working

Comments

@robertying
Copy link
Contributor

Environment

System:
OS: macOS 10.14.5
CPU: (4) x64 Intel(R) Core(TM) i3-8100B CPU @ 3.60GHz
Memory: 224.80 MB / 8.00 GB
Shell: 5.7.1 - /usr/local/bin/zsh
Binaries:
Node: 12.4.0 - /usr/local/Cellar/node/12.4.0/bin/node
Yarn: 1.16.0 - /usr/local/Cellar/node/12.4.0/bin/yarn
npm: 6.9.0 - /usr/local/Cellar/node/12.4.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
IDEs:
Android Studio: 3.4 AI-183.6156.11.34.5522156
Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.6 => 16.8.6
react-native: 0.60.0-rc.1 => 0.60.0-rc.1

Description

I put reactNativeCodePush_androidDeploymentKey in res/values/codepush.xml with:

<resources>
    <string moduleConfig="true" name="reactNativeCodePush_androidDeploymentKey">example</string>
</resources>

But got error in /android/build/generated/rn/src/main/java/com/facebook/react/PackageList.java

error: cannot find symbol
      new AsyncStoragePackage(),new BlurViewPackage(),new RNBackgroundFetchPackage(),new CalendarEventsPackage(),new CodePush(getResources().getString(R.string.reactNativeCodePush_androidDeploymentKey), getApplicationContext(), BuildConfig.DEBUG),new RNDeviceInfo(),new ExtraDimensionsPackage(),new RNGestureHandlerPackage(),new Interactable(),new LinearGradientPackage(),new ReanimatedPackage(),new RNSharePackage(),new VectorIconsPackage(),new RNCWebViewPackage(),new RNFetchBlobPackage()
                                                                                                                                                               ^
  symbol:   variable reactNativeCodePush_androidDeploymentKey
  location: class string

Reproducible Demo

https://github.com/robertying/autolink-issue-example

Run cd android && ./gradlew assembleDebug and you can get the error.

@nerami
Copy link

nerami commented Aug 22, 2019

@robertying do you still have this issue? I noticed that you added reactNativeCodePush_androidDeploymentKey in res/values/codepush.xml. Can you try adding it in res/values/strings.xmls instead? That fixed the problem for me.

@robertying
Copy link
Contributor Author

@NRamirezCR this issue has been resolved by my pull request so it should be good now for everyone. Thanks anyway!

@yasir-netlinks
Copy link

Hi there, I updated code push to latest, but i am still getting this issue!!

@jegathispandian
Copy link

yes. This is the exception I got when I run my app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants