document working with dark mode #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luancurti
approved these changes
Jun 25, 2020
Closed
|
I think this should also be mentioned under "Migration from the older components" as this change in behavior can lead to surprises and confusion easily |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this is to educate users about how to work with dark mode on ios
We could do more: we could check
useColorScheme() === 'dark'and change default picker background color here but that would mean we would depend on appearance api which landed in RN 62 and I think there are still many apps that have not upgraded and they would not be able to use the module.Test Plan
tests pass
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)