feat(ios): videoBitrate option for iOS (#2504)

* Update RNCamera.m Add videoBitrate option for ios, setting video bitrate requires a codec to be set * Update API documentation * Update documentation * Update typings
react-native-camera · Sep 24, 2019 · 38a5ffb · 38a5ffb
1 parent 0026b46
commit 38a5ffb
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 15 deletions.
diff --git a/docs/API.md b/docs/API.md
@@ -76,8 +76,6 @@ interface RecordOptions {
   mute?: boolean;
   mirrorVideo?: boolean;
   path?: string;
-
-  /** Android only */
   videoBitrate?: number;
 
   /** iOS only */
@@ -266,4 +264,4 @@ const isRecording = await isRecording();
 } */
 ```
 
----
+---
diff --git a/docs/RNCamera.md b/docs/RNCamera.md
@@ -555,7 +555,7 @@ Supported options:
 
 - `videoBitrate`. (int greater than 0) This option specifies a desired video bitrate. For example, 5\*1000\*1000 would be 5Mbps.
 
-  - `ios` Not supported.
+  - `ios` Supported however requires that the codec key is also set.
   - `android` Supported.
 
 - `orientation` (string or number). Specifies the orientation that us used for recording the video. Possible values: `"portrait"`, `"portraitUpsideDown"`, `"landscapeLeft"` or `"landscapeRight"`.

diff --git a/ios/RN/RNCamera.m b/ios/RN/RNCamera.m
@@ -599,17 +599,28 @@ - (void)record:(NSDictionary *)options resolve:(RCTPromiseResolveBlock)resolve r
     [connection setVideoOrientation:orientation];
 
     if (options[@"codec"]) {
-      if (@available(iOS 10, *)) {
-        AVVideoCodecType videoCodecType = options[@"codec"];
-        if ([self.movieFileOutput.availableVideoCodecTypes containsObject:videoCodecType]) {
-          [self.movieFileOutput setOutputSettings:@{AVVideoCodecKey:videoCodecType} forConnection:connection];
-          self.videoCodecType = videoCodecType;
-        } else {
-            RCTLogWarn(@"%s: Setting videoCodec is only supported above iOS version 10.", __func__);
+        if (@available(iOS 10, *)) {
+            AVVideoCodecType videoCodecType = options[@"codec"];
+            if ([self.movieFileOutput.availableVideoCodecTypes containsObject:videoCodecType]) {
+                self.videoCodecType = videoCodecType;
+                if(options[@"videoBitrate"]) {
+                    NSString *videoBitrate = options[@"videoBitrate"];
+                    [self.movieFileOutput setOutputSettings:@{
+                      AVVideoCodecKey:videoCodecType,
+                      AVVideoCompressionPropertiesKey:
+                          @{
+                              AVVideoAverageBitRateKey:videoBitrate
+                          }
+                      } forConnection:connection];
+                } else {
+                    [self.movieFileOutput setOutputSettings:@{AVVideoCodecKey:videoCodecType} forConnection:connection];
+                }
+            } else {
+                RCTLogWarn(@"%s: Setting videoCodec is only supported above iOS version 10.", __func__);
+            }
         }
-      }
     }
-
+    
     dispatch_async(self.sessionQueue, ^{
         [self updateFlashMode];
         NSString *path = nil;

diff --git a/types/index.d.ts b/types/index.d.ts
@@ -378,8 +378,6 @@ interface RecordOptions {
   mute?: boolean;
   mirrorVideo?: boolean;
   path?: string;
-
-  /** Android only */
   videoBitrate?: number;
 
   /** iOS only */