Skip to content
This repository has been archived by the owner on Jun 16, 2023. It is now read-only.

Commit

Permalink
feat(android): Improve Android Camera1 error and concurrency handling. (
Browse files Browse the repository at this point in the history 
#2471)

These changes include the following:
- use atomic boolean for capturing photo flag just like video
- add more exception catching and checks
- raise error instead of failing silently if can't capture photo - improve error handling here
- synchronize stop to avoid race conditions and crashes
- delay params updates (surface) if capturing or recording to avoid bugs
- do not allow video or photo capture if already doing video or photo
  • Loading branch information
@cristianoccazinsp @sibelius
cristianoccazinsp authored and sibelius committed Sep 9, 2019
1 parent add1c0c commit a20eb06
Show file tree
Hide file tree
Showing 2 changed files with 140 additions and 75 deletions.
185 changes: 123 additions & 62 deletions android/src/main/java/com/google/android/cameraview/Camera1.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class Camera1 extends CameraViewImpl implements MediaRecorder.OnInfoListener,

private String mVideoPath;

private boolean mIsRecording;
private final AtomicBoolean mIsRecording = new AtomicBoolean(false);

private final SizeMap mPreviewSizes = new SizeMap();

Expand Down Expand Up @@ -120,18 +120,16 @@ class Camera1 extends CameraViewImpl implements MediaRecorder.OnInfoListener,

private boolean mIsScanning;

private boolean mustUpdateSurface;

private SurfaceTexture mPreviewTexture;

Camera1(Callback callback, PreviewImpl preview) {
super(callback, preview);
preview.setCallback(new PreviewImpl.Callback() {
@Override
public void onSurfaceChanged() {
if (mCamera != null) {
setUpPreview();
mIsPreviewActive = false;
adjustCameraParameters();
}
updateSurface();
}

@Override
Expand All @@ -141,6 +139,25 @@ public void onSurfaceDestroyed() {
});
}

private void updateSurface(){
if (mCamera != null) {

// do not update surface if we are currently capturing
// since it will break capture events/video due to the
// pause preview calls
// capture callbacks will handle it if needed afterwards.
if(!isPictureCaptureInProgress.get() && !mIsRecording.get()){
mustUpdateSurface = false;
setUpPreview();
mIsPreviewActive = false;
adjustCameraParameters();
}
else{
mustUpdateSurface = true;
}
}
}

@Override
boolean start() {
chooseCamera();
Expand All @@ -160,25 +177,43 @@ boolean start() {
@Override
void stop() {

mShowingPreview = false;
if (mMediaRecorder != null) {
mMediaRecorder.stop();
mMediaRecorder.release();
mMediaRecorder = null;
// make sure no other threads are trying to do this at the same time
// such as another call to stop() from surface destroyed
// or host destroyed. Should avoid crashes with concurrent calls

synchronized (this) {
if (mMediaRecorder != null) {
try{
mMediaRecorder.stop();
}
catch(RuntimeException e){
Log.e("CAMERA_1::", "mMediaRecorder.stop() failed", e);
}

try{
mMediaRecorder.reset();
mMediaRecorder.release();
}
catch(RuntimeException e){
Log.e("CAMERA_1::", "mMediaRecorder.release() failed", e);
}

if (mIsRecording) {
int deviceOrientation = displayOrientationToOrientationEnum(mDeviceOrientation);
mCallback.onVideoRecorded(mVideoPath, mOrientation != Constants.ORIENTATION_AUTO ? mOrientation : deviceOrientation, deviceOrientation);
mIsRecording = false;
mMediaRecorder = null;

if (mIsRecording.get()) {
int deviceOrientation = displayOrientationToOrientationEnum(mDeviceOrientation);
mCallback.onVideoRecorded(mVideoPath, mOrientation != Constants.ORIENTATION_AUTO ? mOrientation : deviceOrientation, deviceOrientation);
}
}
}

if (mCamera != null) {
mCamera.stopPreview();
mCamera.setPreviewCallback(null);
}
if (mCamera != null) {
mCamera.stopPreview();
mCamera.setPreviewCallback(null);
}
mShowingPreview = false;

releaseCamera();
releaseCamera();
}
}

// Suppresses Camera#setPreviewTexture
Expand Down Expand Up @@ -493,61 +528,77 @@ int displayOrientationToOrientationEnum(int rotation) {
}

void takePictureInternal(final ReadableMap options) {
if (!isPictureCaptureInProgress.getAndSet(true)) {
// if not capturing already, atomically set it to true
if (!mIsRecording.get() && isPictureCaptureInProgress.compareAndSet(false, true)) {

if (options.hasKey("orientation") && options.getInt("orientation") != Constants.ORIENTATION_AUTO) {
mOrientation = options.getInt("orientation");
int rotation = orientationEnumToRotation(mOrientation);
mCameraParameters.setRotation(calcCameraRotation(rotation));
try{
mCamera.setParameters(mCameraParameters);
}
catch(RuntimeException e ) {
Log.e("CAMERA_1::", "setParameters failed", e);
try{
if (options.hasKey("orientation") && options.getInt("orientation") != Constants.ORIENTATION_AUTO) {
mOrientation = options.getInt("orientation");
int rotation = orientationEnumToRotation(mOrientation);
mCameraParameters.setRotation(calcCameraRotation(rotation));
try{
mCamera.setParameters(mCameraParameters);
}
catch(RuntimeException e ) {
Log.e("CAMERA_1::", "setParameters failed", e);
}
}
}

mCamera.takePicture(null, null, null, new Camera.PictureCallback() {
@Override
public void onPictureTaken(byte[] data, Camera camera) {
isPictureCaptureInProgress.set(false);
mCamera.takePicture(null, null, null, new Camera.PictureCallback() {
@Override
public void onPictureTaken(byte[] data, Camera camera) {
isPictureCaptureInProgress.set(false);

// this shouldn't be needed and messes up autoFocusPointOfInterest
// camera.cancelAutoFocus();

if (options.hasKey("pauseAfterCapture") && !options.getBoolean("pauseAfterCapture")) {
camera.startPreview();
mIsPreviewActive = true;
if (mIsScanning) {
camera.setPreviewCallback(Camera1.this);
}
} else {
camera.stopPreview();
mIsPreviewActive = false;
camera.setPreviewCallback(null);
}

// this shouldn't be needed and messes up autoFocusPointOfInterest
// camera.cancelAutoFocus();
mOrientation = Constants.ORIENTATION_AUTO;
mCallback.onPictureTaken(data, displayOrientationToOrientationEnum(mDeviceOrientation));

if (options.hasKey("pauseAfterCapture") && !options.getBoolean("pauseAfterCapture")) {
camera.startPreview();
mIsPreviewActive = true;
if (mIsScanning) {
camera.setPreviewCallback(Camera1.this);
if(mustUpdateSurface){
updateSurface();
}
} else {
camera.stopPreview();
mIsPreviewActive = false;
camera.setPreviewCallback(null);
}

mOrientation = Constants.ORIENTATION_AUTO;
mCallback.onPictureTaken(data, displayOrientationToOrientationEnum(mDeviceOrientation));
}
});
});
}
catch(Exception e){
isPictureCaptureInProgress.set(false);
throw e;
}
}
else{
throw new IllegalStateException("Camera capture failed. Camera is already capturing.");
}
}

@Override
boolean record(String path, int maxDuration, int maxFileSize, boolean recordAudio, CamcorderProfile profile, int orientation) {
if (!mIsRecording) {

// make sure compareAndSet is last because we are setting it
if (!isPictureCaptureInProgress.get() && mIsRecording.compareAndSet(false, true)) {
if (orientation != Constants.ORIENTATION_AUTO) {
mOrientation = orientation;
}
setUpMediaRecorder(path, maxDuration, maxFileSize, recordAudio, profile);
try {
setUpMediaRecorder(path, maxDuration, maxFileSize, recordAudio, profile);
mMediaRecorder.prepare();
mMediaRecorder.start();
mIsRecording = true;
return true;
} catch (IOException e) {
e.printStackTrace();
} catch (Exception e) {
mIsRecording.set(false);
Log.e("CAMERA_1::", "Record start failed", e);
return false;
}
}
Expand All @@ -556,11 +607,14 @@ boolean record(String path, int maxDuration, int maxFileSize, boolean recordAudi

@Override
void stopRecording() {
if (mIsRecording) {
if (mIsRecording.compareAndSet(true, false)) {
stopMediaRecorder();
if (mCamera != null) {
mCamera.lock();
}
if(mustUpdateSurface){
updateSurface();
}
}
}

Expand Down Expand Up @@ -594,15 +648,15 @@ void setDeviceOrientation(int deviceOrientation) {
return;
}
mDeviceOrientation = deviceOrientation;
if (isCameraOpened() && mOrientation == Constants.ORIENTATION_AUTO && !mIsRecording) {
if (isCameraOpened() && mOrientation == Constants.ORIENTATION_AUTO && !mIsRecording.get() && !isPictureCaptureInProgress.get()) {
mCameraParameters.setRotation(calcCameraRotation(deviceOrientation));
try{
mCamera.setParameters(mCameraParameters);
}
catch(RuntimeException e ) {
Log.e("CAMERA_1::", "setParameters failed", e);
}
}
}
}

@Override
Expand Down Expand Up @@ -763,6 +817,10 @@ private void releaseCamera() {
mCamera = null;
mPictureSize = null;
mCallback.onCameraClosed();

// reset these flags
isPictureCaptureInProgress.set(false);
mIsRecording.set(false);
}
}

Expand Down Expand Up @@ -1074,6 +1132,7 @@ public void onPreviewFrame(byte[] data, Camera camera) {
}

private void setUpMediaRecorder(String path, int maxDuration, int maxFileSize, boolean recordAudio, CamcorderProfile profile) {

mMediaRecorder = new MediaRecorder();
mCamera.unlock();

Expand Down Expand Up @@ -1107,15 +1166,16 @@ private void setUpMediaRecorder(String path, int maxDuration, int maxFileSize, b

mMediaRecorder.setOnInfoListener(this);
mMediaRecorder.setOnErrorListener(this);

}

private void stopMediaRecorder() {
mIsRecording = false;

if (mMediaRecorder != null) {
try {
mMediaRecorder.stop();
} catch (RuntimeException ex) {
ex.printStackTrace();
Log.e("CAMERA_1::", "stopMediaRecorder failed", ex);
}
mMediaRecorder.reset();
mMediaRecorder.release();
Expand All @@ -1130,6 +1190,7 @@ private void stopMediaRecorder() {

mCallback.onVideoRecorded(mVideoPath, mOrientation != Constants.ORIENTATION_AUTO ? mOrientation : deviceOrientation, deviceOrientation);
mVideoPath = null;

}

private void setCamcorderProfile(CamcorderProfile profile, boolean recordAudio) {
Expand Down
30 changes: 17 additions & 13 deletions android/src/main/java/org/reactnative/camera/CameraModule.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ private Map<String, Object> getBarCodeConstants() {
}
});
}

@ReactMethod
public void pausePreview(final int viewTag) {
final ReactApplicationContext context = getReactApplicationContext();
Expand All @@ -217,7 +217,7 @@ public void pausePreview(final int viewTag) {
@Override
public void execute(NativeViewHierarchyManager nativeViewHierarchyManager) {
final RNCameraView cameraView;

try {
cameraView = (RNCameraView) nativeViewHierarchyManager.resolveView(viewTag);
if (cameraView.isCameraOpened()) {
Expand All @@ -229,7 +229,7 @@ public void execute(NativeViewHierarchyManager nativeViewHierarchyManager) {
}
});
}

@ReactMethod
public void resumePreview(final int viewTag) {
final ReactApplicationContext context = getReactApplicationContext();
Expand All @@ -238,7 +238,7 @@ public void resumePreview(final int viewTag) {
@Override
public void execute(NativeViewHierarchyManager nativeViewHierarchyManager) {
final RNCameraView cameraView;

try {
cameraView = (RNCameraView) nativeViewHierarchyManager.resolveView(viewTag);
if (cameraView.isCameraOpened()) {
Expand All @@ -261,14 +261,18 @@ public void takePicture(final ReadableMap options, final int viewTag, final Prom
public void execute(NativeViewHierarchyManager nativeViewHierarchyManager) {
RNCameraView cameraView = (RNCameraView) nativeViewHierarchyManager.resolveView(viewTag);
try {
if (cameraView.isCameraOpened()) {
cameraView.takePicture(options, promise, cacheDirectory);
} else {
promise.reject("E_CAMERA_UNAVAILABLE", "Camera is not running");
}
} catch (Exception e) {
promise.reject("E_CAMERA_BAD_VIEWTAG", "takePictureAsync: Expected a Camera component");
}
if (cameraView.isCameraOpened()) {
cameraView.takePicture(options, promise, cacheDirectory);
} else {
promise.reject("E_CAMERA_UNAVAILABLE", "Camera is not running");
}
}
catch(IllegalStateException e){
promise.reject("E_CAMERA_UNAVAILABLE", e.getMessage());
}
catch (Exception e) {
promise.reject("E_CAMERA_BAD_VIEWTAG", e.getMessage());
}
}
});
}
Expand Down Expand Up @@ -353,7 +357,7 @@ public void getAvailablePictureSizes(final String ratio, final int viewTag, fina
@Override
public void execute(NativeViewHierarchyManager nativeViewHierarchyManager) {
final RNCameraView cameraView;

try {
cameraView = (RNCameraView) nativeViewHierarchyManager.resolveView(viewTag);
WritableArray result = Arguments.createArray();
Expand Down

0 comments on commit a20eb06

Please sign in to comment.