-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working with RN 0.51.0-rc.2 #240
Comments
I have the same issue |
Same error, using RN 0.51 |
This is addressed in #243, so if you guys want a quick fix until the PR is merged, you can fork/depend on the code in @bilalsyed001's branch. |
fixed on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While upgrading my app the the currently latest RN release candidate (0.51.0-rc.2), the usage of this module crashes the app but it appears that it's an issue of React Native itself.
Basically, the
start
andend
properties are not correctly handled by RN. I get this error:It seems as if RN is considering that
start
andend
are@ReactPropGroup
instead of@ReactProp
. I've changed this module locally to use the prop name "startsomething" instead of "start" and it worked again.I've opened an issue in the RN repo itself: facebook/react-native#17030
This is not an issue report but rather an FYI.
The text was updated successfully, but these errors were encountered: