Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with RN 0.51.0-rc.2 #240

Closed
tiagoalves opened this issue Nov 30, 2017 · 5 comments
Closed

Not working with RN 0.51.0-rc.2 #240

tiagoalves opened this issue Nov 30, 2017 · 5 comments

Comments

@tiagoalves
Copy link

While upgrading my app the the currently latest RN release candidate (0.51.0-rc.2), the usage of this module crashes the app but it appears that it's an issue of React Native itself.

Basically, the start and end properties are not correctly handled by RN. I get this error:

TypeError: expected dynamic type 'double', but had type 'array'

It seems as if RN is considering that start and end are @ReactPropGroup instead of @ReactProp. I've changed this module locally to use the prop name "startsomething" instead of "start" and it worked again.

I've opened an issue in the RN repo itself: facebook/react-native#17030

This is not an issue report but rather an FYI.

@Kottidev
Copy link

Kottidev commented Dec 7, 2017

approved

image

@wellyshen
Copy link

I have the same issue

@pithcou
Copy link

pithcou commented Dec 7, 2017

Same error, using RN 0.51
TypeError: expected dynamic type 'double', but had type 'array'

@MichaelDanielTom
Copy link

This is addressed in #243, so if you guys want a quick fix until the PR is merged, you can fork/depend on the code in @bilalsyed001's branch.

@sibelius
Copy link
Collaborator

fixed on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants