Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

0.57.7 Discussion #71

Closed
kelset opened this issue Nov 27, 2018 · 11 comments
Closed

0.57.7 Discussion #71

kelset opened this issue Nov 27, 2018 · 11 comments
Labels
backport request Cherry picking a change into an existing release stable Stable version

Comments

@kelset
Copy link
Member

kelset commented Nov 27, 2018

Conversation on this thread are limited to 0.57.7 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.57.8 release in the near future.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.7 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.57-stable branch yourself, in order to ensure that the process proceeds smoothly.

@kelset kelset added stable Stable version backport request Cherry picking a change into an existing release labels Nov 27, 2018
@miblanchard
Copy link

Could 53da585 be cherry-picked?

@ahce
Copy link

ahce commented Dec 4, 2018

React sync

@radeno
Copy link

radeno commented Dec 5, 2018

Some other possible fixing cherry-picks

Maybe:

@dvicory
Copy link

dvicory commented Dec 5, 2018

👍 on facebook/react-native@8d68a3e. That metro upgrade contains the Yarn PnP resolver that I really want to make use of. 😄

@radeno
Copy link

radeno commented Dec 7, 2018

Another fixes:

Maybe:

@kelset
Copy link
Member Author

kelset commented Dec 10, 2018

hey everyone, thanks for the suggestions, I am thinking of releasing 0.57.8 by end of the week as last release for 0.57 for this year.

I'll keep you updated.


EDIT: I won't upgrade Metro because it relies on an alpha of Jest. You are free to enforce it in your local project, but for this branch we are trying to keep things as stable as possible.

@levibuzolic
Copy link

levibuzolic commented Dec 10, 2018

Any chance we could get facebook/react-native@077386a into 0.57.8? Or would it be more appropriate for the 0.58.0 release?

Oops never mind, got reverted. Will wait to find out what happened and get it back in. 🤦‍♂️

@radeno
Copy link

radeno commented Dec 11, 2018

@levibuzolic that commit was reverted. So i don't think so.

@sunnylqm
Copy link
Contributor

@kelset
Copy link
Member Author

kelset commented Dec 12, 2018

Hey everyone, just cherry-picked the commits, tested locally all everything went smoothly - now pushed to repo to test CI. You can see the list of commits here.

Didn't cherry pick because created conflicts:

@kelset
Copy link
Member Author

kelset commented Dec 13, 2018

Release 0.57.8 is now on npm, I'll publish the changelog in a bit.

Thanks to everyone who got involved, you can follow up the conversation for 0.57.8 in its dedicated issue.

@kelset kelset closed this as completed Dec 13, 2018
@react-native-community react-native-community locked as resolved and limited conversation to collaborators Dec 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport request Cherry picking a change into an existing release stable Stable version
Projects
None yet
Development

No branches or pull requests

7 participants