0.58.4 Discussion

[grabbou]

Conversation on this thread are limited to 0.58.0 release's major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.58.4 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.58-stable branch yourself, in order to ensure that the process proceeds smoothly.

[mikehardy]

@dulmandakh this is showing up when I look at the patches - pvinis/rn-diff-purge@version/0.58.4...version/0.59.0-rc.0 - it appears to be incorporated already?

[dulmandakh]

Yep, it's in 0.59, so I proposed it for 0.58.5 if released. I learned that people are changing targetSDK to 28 and having network issues with 0.58 release, because Android Studio is suggesting to use the latest or 28 version.

…

[andresmtz98]

Yep, it's in 0.59, so I proposed it for 0.58.5 if released. I learned that people are changing targetSDK to 28 and having network issues with 0.58 release, because Android Studio is suggesting to use the latest or 28 version.
…

Yes, it will be pretty good if you release .58.5 for the Android issues with sdk 28.

[grabbou]

I will be releasing another 0.58 release tomorrow with the commits mentioned.

[grabbou]

Cherry-picked almost all the commits.

@Jyrno42, your commit is already part of the release.
@noahtallen, I didn't cherry-pick your commit since it's already part of 0.59 where it's been deprecated too. I think it's good to not cherry-pick deprecations. I hope it's not a deal breaker for you.

Waiting for the tests to pass.

[noahtallen]

@grabbou no problem! That certainly makes sense. My hope was that it would help with a different issue I was having related to react native screens.

[grabbou]

I understand! In this case, one thing I can do for you is to encourage you to try the RC :)

[cihati]

(I apologize, I still haven't figured out how it's decided that certain commits are put into certain releases. Any pointers would be helpful)

@grabbou Any chance to get facebook/react-native#22439 into the next release, assuming there will be 0.58.5 release? It's merged on Jan 2nd, and our app crashes a lot due to this issue. I see that the fix's already in the 0.59 branch: https://github.com/facebook/react-native/blob/0.59-stable/Libraries/WebSocket/RCTSRWebSocket.m

[mikehardy]

@cihati I think you just ask for a specific commit, like so facebook/react-native@dd209bb in this case?

[cihati]

Yes, that's the commit -- sorry I put the PR link initially instead.

[grabbou]

I'll include that one too, just doing final touches before the release.

[cihati]

@grabbou many thanks!! Just for my understanding: what's the release process timeline like in general? For instance, I see that you bumped version numbers to 0.58.5 ~4 hours ago ( facebook/react-native@9d90696 ) but I don't see the new react-native version in NPM yet (or in CHANGELOG.md)

[grabbou]

Generally speaking, it takes an hour from the tag pushed to Github to land on npm. Unfortunately, the CircleCI failed to checkout the code (https://circleci.com/gh/facebook/react-native/73354). I am investigating the issue.

[grabbou]

The CI is back green and 0.58.5 is out.

[andresmtz98]

Hmm the problem with internet connection on Android still persists with sdk 28 :(. Or there is any config to do? Or this release doesn't included that fix?

[kelset]

@andresmtz98 can you comment on the related issue on the main repo? So that we can close this, open a new one for 0.58.6 if we decide to do a next one (before 0.59.0).

(also, you should double check that the issue is still present on the 0.59 rc)

[kelset]

Closing in favor of -> #95