Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: reverse dep order, google then jcenter #387

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

mikehardy
Copy link
Collaborator

Fixes #386 where jcenter had a POM but 404d the artifact, breaking builds,
while google has the POM and artifact (as it's a google support library)

Also, jcenter is a superset of mavenCentral, so mavenCentral is
redundant:
https://jfrog.com/knowledge-base/why-should-i-use-jcenter-over-maven-central/

Fixes react-native-share#386 where jcenter had a POM but 404d the artifact, breaking builds,
while google has the POM and artifact (as it's a google support library)

Also, jcenter is a superset of mavenCentral, so mavenCentral is
redundant:
https://jfrog.com/knowledge-base/why-should-i-use-jcenter-over-maven-central/
@jgcmarins jgcmarins merged commit 2c91ecc into react-native-share:master Oct 23, 2018
@mikehardy
Copy link
Collaborator Author

If you need access to this change prior to a release, you can ask npm or yarn to install from github instead of a release version, like so quoted from the issue:

If you want to check to see if the code in master will work, regardless, you can alter the react-native-share dependency in you package.json as a test to "git+https://github.com/react-native-community/react-native-share.git" and run an npm install - that's how you ask npm (or yarn) to pull github master of any dependency, as opposed to using release packages.

@padupuy
Copy link

padupuy commented Oct 23, 2018

@mikehardy thanks for the quick fix, could you release a new version soon ? Meanwhile the next release I will fork the project

@padupuy
Copy link

padupuy commented Oct 23, 2018

perfect, you rocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants