This repository has been archived by the owner on Nov 27, 2022. It is now read-only.
Adding accessibility role and state #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Utilizing the new accessibility properties provided in react-native 0.57.0. It did not seem to work using the currently deprecated properties on my test devices.
Test plan
Steps to test:
Selected. TabName. Tab. x of y. Button. Previously, it would readTabName. Tab. x of y.It seems like there was an effort to manually assign the role of
Tabthrough theaccessibilityLabelprop. However, that is not in the list of available accessibility roles. Personally, I think it's helpful to have bothTabandButtonannounced, but I can remove/change it as needed.