Fix: volume should not change on onAudioFocusChange event #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddudek
changed the title
ddudek
changed the title
|
Well done! Nice diagnosis and fix. When muting, we should save the current volume and restore it when unmuting, but that can be a separate fix. Feel free to push a separate PR for that. |
beauner69
pushed a commit
to beauner69/react-native-video
that referenced
this pull request
Oct 10, 2019
…e_focus_change Fix: volume should not change on onAudioFocusChange event (rebased from commit 1207d45)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the documentation
Not a new feature
Update the changelog
Updated.
Provide an example of how to test the change
Result: volume is set to 0.8f for a while and then resets to 1.0f
Expected: volume should set to 0.8 of current volume, and then get back to previous volume
Describe the changes
I'm saving current volume in a field, and make audio focus change listener use the current volume value instead of harcoded levels.