Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds onPlaybackRateChange info to README #1578

Merged
merged 4 commits into from
Jun 12, 2019
Merged

Adds onPlaybackRateChange info to README #1578

merged 4 commits into from
Jun 12, 2019

Conversation

JoeM-RP
Copy link

@JoeM-RP JoeM-RP commented May 3, 2019

Describe the changes

Added a brief summary of 'onPlaybackRateChange' to the README based on comments for #193

@CHaNGeTe
Copy link
Contributor

Thanks for adding it to the README
AFAIK playbackRate can also be, for example, 0.5

@JoeM-RP
Copy link
Author

JoeM-RP commented Jun 11, 2019

@CHaNGeTe - any sense of what state might be indicated by 0.5? I can update the language to be more explicit

@CHaNGeTe
Copy link
Contributor

CHaNGeTe commented Jun 11, 2019

@CHaNGeTe CHaNGeTe requested a review from cobarx June 11, 2019 20:54
@CHaNGeTe CHaNGeTe merged commit e28ae17 into TheWidlarzGroup:master Jun 12, 2019
beauner69 pushed a commit to beauner69/react-native-video that referenced this pull request Oct 10, 2019
Adds onPlaybackRateChange info to README

(rebased from commit e28ae17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants