Fixes bug where poster and video was displayed simultaneously #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CHaNGeTe I'm happy with this one now, but need help testing. Especially on android and the ExoPlayer. We need to verify that |
|
@CHaNGeTe I just pushed a commit that hides the poster in |
CHaNGeTe
approved these changes
Jun 21, 2019
beauner69
pushed a commit
to beauner69/react-native-video
that referenced
this pull request
Oct 10, 2019
Fixes bug where poster and video was displayed simultaneously (rebased from commit 3a7be63)
|
"react-native": "0.61.5" React Native Android Black Screen For Android |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using poster image and not using absolute positioning of the Video element you end up with both video and poster elements. This was introduced in #1167. My fix to revert some changes but keep the benefits of no flashing.
This fix relies on
onReadyForDisplaycallback to hide the poster. It's been tested on iOS and ExoPlayer. I added it to DOM as well but haven't been able to test...Fixes 1509