Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak on iOS when using controls (AVPlayerViewController) #1647

Merged
merged 3 commits into from
Jul 4, 2019

Conversation

jenshandersson
Copy link
Contributor

When using controls={true} on iOS we use AVPlayerViewController, but we weren't releasing the AVPlayer instance correctly. This is a simple fix but should lead to much better memory consumption when using controls.

Hopefully fixes #113 (and hopefully more related ones)

@CHaNGeTe CHaNGeTe changed the base branch from master to release/4.4.3 July 4, 2019 08:04
@CHaNGeTe CHaNGeTe merged commit 1433d16 into TheWidlarzGroup:release/4.4.3 Jul 4, 2019
@CHaNGeTe CHaNGeTe mentioned this pull request Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants