Remove exoplayer deprecations and bump Exoplayer #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 16, 2019 13:32
- Bump Exoplayer to 2.10.4 - Remove deprecated usages of Exoplayer methdos - Add `ReactExoplayerConfig` as extension points to configure the Exoplayer instance
benoitdion
changed the title
ethanperez
reviewed
Sep 17, 2019
| // Deprecated RN 0.47 | ||
| public List<Class<? extends JavaScriptModule>> createJSModules() { | ||
| return Collections.emptyList(); | ||
| } |
There was a problem hiding this comment.
Since v5.0 supports RN 0.60+, I think it's safe to remove this
CHaNGeTe
reviewed
Sep 21, 2019
| @@ -0,0 +1,10 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
this is part of the RN 0.60 template. I'm hoping to simplify some of this in the future but was trying to do the minimum possible to get the example running.
CHaNGeTe
reviewed
Sep 21, 2019
| implementation "com.facebook.react:react-native:+" // From node_modules | ||
| implementation 'org.webkit:android-jsc:+' |
There was a problem hiding this comment.
this is part of the RN 0.60 template. I'm hoping to simplify some of this in the future but was trying to do the minimum possible to get the example running.
CHaNGeTe
approved these changes
Sep 21, 2019
This was referenced Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the changelog
[] Update changelog
Describe the changes
ReactExoplayerConfigas extension points to configure the Exoplayer instanceRelated PRs