-
Notifications
You must be signed in to change notification settings - Fork 404
0.61.3 Discussion #150
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@tlvenn I am watching software-mansion/react-native-gesture-handler#320 (comment) intently as it causes a crash bug in my app without the workaround. From commentary several of the attentive maintainers are similar watching (cough @kelset cough). I checked the file that is actually in 0.61-stable and the react-native commit is there https://github.com/facebook/react-native/blob/0.61-stable/Libraries/Components/View/ReactNativeViewViewConfig.js#L106 - it has been there for all of 0.61 but for some reason the issue is still happening in the repo. @grabbou I don't think there's anything to do on the react-native side for facebook/react-native@942de57#diff-1eaa4391573b4aa3e399dafeb401f47fR105 - it really is there already I think the right thing to do is continue conversation on Issue software-mansion/react-native-gesture-handler#320 and Pull software-mansion/react-native-gesture-handler#792 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thank you for the participation in the discussion and @mikehardy for helping me with the moderation! I really appreciate that - sometimes it's just too many things to coordinate! Let me look into the commits right now - I will proceed with fixes and cherry-picks and hopefully, we can have another release today. Expect an update from me soon! |
Thanks @tlvenn and @nar213 for providing both issue and commit. Helps with the process! |
No more requests for this release. Waiting for the tests and will push to |
Conversations on this thread are limited to 0.61 releases major issues and backport (cherry-pick) requests from commits that are already on master.
An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.61.3 cut.
In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.
The text was updated successfully, but these errors were encountered: