Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

0.61.3 Discussion #150

Closed
grabbou opened this issue Oct 29, 2019 · 16 comments
Closed

0.61.3 Discussion #150

grabbou opened this issue Oct 29, 2019 · 16 comments
Labels
backport request Cherry picking a change into an existing release stable Stable version

Comments

@grabbou
Copy link
Member

grabbou commented Oct 29, 2019

Conversations on this thread are limited to 0.61 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.61.3 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

@grabbou grabbou added stable Stable version backport request Cherry picking a change into an existing release labels Oct 29, 2019
@LuigiMaestrelli

This comment has been minimized.

@mikehardy

This comment has been minimized.

@tlvenn

This comment has been minimized.

@pvinis

This comment has been minimized.

@pvinis

This comment has been minimized.

@RichardLindhout

This comment has been minimized.

@mikehardy
Copy link

@tlvenn I am watching software-mansion/react-native-gesture-handler#320 (comment) intently as it causes a crash bug in my app without the workaround. From commentary several of the attentive maintainers are similar watching (cough @kelset cough). I checked the file that is actually in 0.61-stable and the react-native commit is there https://github.com/facebook/react-native/blob/0.61-stable/Libraries/Components/View/ReactNativeViewViewConfig.js#L106 - it has been there for all of 0.61 but for some reason the issue is still happening in the repo.

@grabbou I don't think there's anything to do on the react-native side for facebook/react-native@942de57#diff-1eaa4391573b4aa3e399dafeb401f47fR105 - it really is there already

I think the right thing to do is continue conversation on Issue software-mansion/react-native-gesture-handler#320 and Pull software-mansion/react-native-gesture-handler#792

@tlvenn

This comment has been minimized.

@tlvenn

This comment has been minimized.

@kelset

This comment has been minimized.

@compojoom

This comment has been minimized.

@narobertson42

This comment has been minimized.

@mikehardy

This comment has been minimized.

@grabbou
Copy link
Member Author

grabbou commented Nov 4, 2019

Thank you for the participation in the discussion and @mikehardy for helping me with the moderation! I really appreciate that - sometimes it's just too many things to coordinate!

Let me look into the commits right now - I will proceed with fixes and cherry-picks and hopefully, we can have another release today.

Expect an update from me soon!

@grabbou
Copy link
Member Author

grabbou commented Nov 4, 2019

Thanks @tlvenn and @nar213 for providing both issue and commit. Helps with the process!

@grabbou
Copy link
Member Author

grabbou commented Nov 4, 2019

No more requests for this release. Waiting for the tests and will push to npm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport request Cherry picking a change into an existing release stable Stable version
Projects
None yet
Development

No branches or pull requests

9 participants