Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

0.61.4 #151

Closed
grabbou opened this issue Nov 4, 2019 · 12 comments
Closed

0.61.4 #151

grabbou opened this issue Nov 4, 2019 · 12 comments
Labels
backport request Cherry picking a change into an existing release stable Stable version

Comments

@grabbou
Copy link
Member

grabbou commented Nov 4, 2019

Conversations on this thread are limited to 0.61 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.61.4 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

@grabbou grabbou added stable Stable version backport request Cherry picking a change into an existing release labels Nov 4, 2019
@thymikee
Copy link
Member

thymikee commented Nov 5, 2019

Please cherry pick:

If 0.62 is not going to be re-cut, please pick this there as well.

@pinstripe-potatohead
Copy link

Please cherry pick

  • Fix multiple set-cookie not aggregated correctly in response headers @1df8bd4

@grabbou
Copy link
Member Author

grabbou commented Nov 13, 2019

@thymikee, at this point, the conclusion is that we will not be re-cutting 0.62. I am going to release its preview now and will cherry-pick that one in the next iteration.

@grabbou
Copy link
Member Author

grabbou commented Nov 13, 2019

I am going to work on 0.62 right now and will get back to this issue in few days (later this week) and we will release another update.

@thymikee
Copy link
Member

CLI bump: facebook/react-native@e523302

@dnlowman
Copy link

Please cherry pick

* Fix multiple `set-cookie` not aggregated correctly in response headers [@1df8bd4](https://github.com/facebook/react-native/commit/1df8bd4932f42958c01dccf44cee92b75a6988ed)

Is this going to be backported? or is it scheduled for a later release? This is quite a big issue for us relying on cookies.

@niparx
Copy link

niparx commented Nov 19, 2019

Add this, please: Bump SoLoader to 0.8.0

This fixes RN support for Android Bundle. See here for one of the issues. To be short: SoLoader can't find libraries, when app is installed to device from a Bundle

@radko93
Copy link

radko93 commented Nov 19, 2019

@niparx, unfortunately, this commit breaks 0.61.x branch so cannot be cherry-picked. But it's already there in RC 0.62.

@mikehardy
Copy link

mikehardy commented Nov 19, 2019

@radko93 0.62-stable branch does not actually have an RC tag or package release yet but if I understand correctly it is buildable / green on CI with the exception of a regression to the need for the android gradle library pickFirst workaround returning (until fixed)
#145 - which is to say, if I really needed app bundles and I was handy with doing an internal build/release of react-native (not easy, but not that hard) I might give 0.62-stable a whirl but otherwise it's not really available yet.

Not that that commit should be worked into 0.61.x or anything - just as information in case others are looking+waiting for that one

@grabbou
Copy link
Member Author

grabbou commented Nov 22, 2019

Because 0.62 is going to wait for a few days, time to get back on this one and release fixes. Thank you @radko93 and @mikehardy for helping with the issues moderation! That is really appreciated!

@grabbou
Copy link
Member Author

grabbou commented Nov 23, 2019

All commits cherry-picked. The release is on CircleCI and will be out soon.

@grabbou
Copy link
Member Author

grabbou commented Nov 23, 2019

Closing as 0.61.5 is on CircleCI. Matter of ~30 minutes.

@grabbou grabbou closed this as completed Nov 23, 2019
@react-native-community react-native-community locked as resolved and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport request Cherry picking a change into an existing release stable Stable version
Projects
None yet
Development

No branches or pull requests

7 participants