Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dependency warning #173

Closed
ahce opened this issue May 19, 2020 · 3 comments · Fixed by #191
Closed

Peer dependency warning #173

ahce opened this issue May 19, 2020 · 3 comments · Fixed by #191

Comments

@ahce
Copy link

ahce commented May 19, 2020

Bug report

Summary

should be optional dependency? I don't use react-native-windows

npm WARN @react-native-community/datetimepicker@2.4.0 requires a peer of react-native-windows@^0.62.0-preview.1 but none is installed. You must install peer dependencies yourself.

Environment info

react-native info output:

System:
    OS: Windows 10 10.0.18363
    CPU: (4) x64 Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz
    Memory: 6.90 GB / 19.66 GB
  Binaries:
    Node: 12.16.3 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.4 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.14.5 - C:\Program Files\nodejs\npm.CMD
    Watchman: Not Found
  SDKs:
    Android SDK:
      API Levels: 23, 24, 25, 26, 27, 28, 29
      Build Tools: 19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 24.0.1, 24.0.2, 24.0.3, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.0, 26.0.1, 26.0.2, 26.0.3, 27.0.0, 27.0.1, 27.0.2, 27.0.3, 28.0.0, 28.0.1, 28.0.2, 28.0.3, 29.0.0, 29.0.1, 29.0.2, 29.0.3
      System Images: android-21 | Google APIs Intel x86 Atom_64, android-22 | Intel x86 Atom_64, android-22 | Google APIs Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom_64, android-24 | Google Play Intel x86 Atom, android-25 | Google Play Intel x86 Atom, android-26 | Google Play Intel x86 Atom, android-27 | Google APIs Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-29 | Google Play Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: Version  3.6.0.0 AI-192.7142.36.36.6308749
  Languages:
    Java: 1.8.0_231 - C:\Program Files\Java\jdk1.8.0_231\bin\javac.EXE
    Python: Not Found
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.11.0 => 16.11.0
    react-native: 0.62.2 => 0.62.2
  npmGlobalPackages:
    *react-native*: Not Found

Library version: 2.4.0

Steps to reproduce

  1. npm i @react-native-community/datetimepicker --save

Describe what you expected to happen:

  1. No peer warn.
@luancurti
Copy link
Member

@ahce What do you suggest to fix this warning? I do not see a problem with this warning because react-native-windows is necessary if you would like to use the datetimepicker in windows this warning only record the developer in case you forgot to add it

@ahce
Copy link
Author

ahce commented May 22, 2020

@ahce What do you suggest to fix this warning? I do not see a problem with this warning because react-native-windows is necessary if you would like to use the datetimepicker in windows this warning only record the developer in case you forgot to add it

I think if i develop for react-native-windows, i will make sure to install it.
My suggest is move react-native-windows to optionalDependencies.

@luancurti
Copy link
Member

@ahce feel free to open a PR with your suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants