Add NuGet AssetTargetFallback #578
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
My C# module builds with this kind of hacks on c# app (react-native-windows 0.68) but i am not really sure what is valid solution. EDIT: this is not yet final solution to get c# module build on c# app EDIT: some kind of solution found microsoft/react-native-windows#10059 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm taking a stab at resolving the issue
microsoft/react-native-windows#10059 (comment)
Summary
Currently, RNDocumentPicker doesn't build against react-native 0.69.1/react-native-windows 0.69.1 because of a bug in the way that r-n-w handles older dependencies (built with a previous target version)—see the discussion on the thread mentioned above.
One of the suggestions was to update the csproj's
AssetTargetFallbackhandling, which is what this PR does.I'm hoping this PR will resolve #562
Test Plan
I can't figure out how to build the RNDocumentPicker project on my vscode 2019 (and I could use some help verifying that this PR resolves the 0.69.1 issues). For now, I'm punting and asking for someone who knows how to build/deploy to try building this so I can see if it resolves the issues.
What's required for testing (prerequisites)?
Try to build a UWP app that references RNDocumentPicker with react-native-windows 0.69.1 and no longer see builds fail due to issue 562.
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdI'm getting
1>...\react-native-document-picker\windows\ReactNativeDocumentPicker\ReactNativeDocumentPicker.csproj(144,5): error : This project references targets in your node_modules\react-native-windows folder that are missing. The missing file is \node_modules\react-native-windows\\PropertySheets\External\Microsoft.ReactNative.Uwp.CSharpLib.props.and have no clue where or how to resolve that, for the project.