-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): utility type removed from RN 0.71 #187
Merged
Naturalclar
merged 1 commit into
react-native-masked-view:master
from
alpha0010:patch-1
Feb 23, 2023
Merged
fix(types): utility type removed from RN 0.71 #187
Naturalclar
merged 1 commit into
react-native-masked-view:master
from
alpha0010:patch-1
Feb 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can anyone review & merge it? |
Naturalclar
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jeanregisser
referenced
this pull request
in valora-inc/wallet
May 24, 2023
… ^0.2.9 (#3794) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@react-native-masked-view/masked-view](https://github.com/react-native-masked-view/masked-view) | [`^0.2.8` -> `^0.2.9`](https://renovatebot.com/diffs/npm/@react-native-masked-view%2fmasked-view/0.2.8/0.2.9) | [![age](https://badges.renovateapi.com/packages/npm/@react-native-masked-view%2fmasked-view/0.2.9/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@react-native-masked-view%2fmasked-view/0.2.9/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@react-native-masked-view%2fmasked-view/0.2.9/compatibility-slim/0.2.8)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@react-native-masked-view%2fmasked-view/0.2.9/confidence-slim/0.2.8)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-masked-view/masked-view</summary> ### [`v0.2.9`](https://github.com/react-native-masked-view/masked-view/releases/tag/v0.2.9) [Compare Source](https://github.com/react-native-masked-view/masked-view/compare/v0.2.8...v0.2.9) #### What's Changed - docs(readme): overall improvements by [@​LRNZ09](https://github.com/LRNZ09) in [https://github.com/react-native-masked-view/masked-view/pull/173](https://github.com/react-native-masked-view/masked-view/pull/173) - feat(example): add multiple component examples app by [@​LRNZ09](https://github.com/LRNZ09) in [https://github.com/react-native-masked-view/masked-view/pull/176](https://github.com/react-native-masked-view/masked-view/pull/176) - Web stub ([#​70](https://github.com/react-native-masked-view/masked-view/issues/70)) by [@​hexadecy](https://github.com/hexadecy) in [https://github.com/react-native-masked-view/masked-view/pull/175](https://github.com/react-native-masked-view/masked-view/pull/175) - Update node version used in CI by [@​Naturalclar](https://github.com/Naturalclar) in [https://github.com/react-native-masked-view/masked-view/pull/177](https://github.com/react-native-masked-view/masked-view/pull/177) - fix(types): utility type removed from RN 0.71 by [@​alpha0010](https://github.com/alpha0010) in [https://github.com/react-native-masked-view/masked-view/pull/187](https://github.com/react-native-masked-view/masked-view/pull/187) #### New Contributors - [@​LRNZ09](https://github.com/LRNZ09) made their first contribution in [https://github.com/react-native-masked-view/masked-view/pull/173](https://github.com/react-native-masked-view/masked-view/pull/173) - [@​hexadecy](https://github.com/hexadecy) made their first contribution in [https://github.com/react-native-masked-view/masked-view/pull/175](https://github.com/react-native-masked-view/masked-view/pull/175) - [@​alpha0010](https://github.com/alpha0010) made their first contribution in [https://github.com/react-native-masked-view/masked-view/pull/187](https://github.com/react-native-masked-view/masked-view/pull/187) **Full Changelog**: react-native-masked-view/masked-view@v0.2.8...v0.2.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS45OC40IiwidXBkYXRlZEluVmVyIjoiMzUuOTguNCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jean Regisser <jean.regisser@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updating to react native 0.71, TypeScript errors on this library. The utility type
Constructor
is private in latest typings. Using this export degrades toany
type.JSX element class does not support attributes because it does not have a 'props' property.
Test Plan
npx tsc
runs clean after making this change on a RN 0.71 app.