-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow using WinUI 3 Controls #342
Conversation
WinUI 3 controls are in a separate namespace than system XAML. `react-native-windows` exports headers making it easier to target both, with the right control resolved based on user settings. This changes includes of System XAML to the aliased versions instead. It conditionally removes references to versioned System XAML interfaces as well. Mirrors the following patch in the RNW repo: https://github.com/microsoft/react-native-windows/blob/main/patches/%40react-native-picker%2Bpicker%2B2.1.0.patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gets us closer but I think this won't quite work e2e without including experimentalFeatures from the app (someone needs to set USE_WINUI3 for the module project based on the app's choice)
The template library includes ExperimentalFeatures.props for us IIRC. This patch is what we're using in the repo right now for WinUI 3 Playground. |
Hmm, I don't see it being imported in the project. I will add the reference, as it is in the 0.65 template. Curious how this was resolving to WINUI 3 in the RNW repo 🤨. |
@asklar @Naturalclar could you take another look? |
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
WinUI 3 controls are in a separate namespace than system XAML.
react-native-windows
exports headers making it easier to target both, with the right control resolved based on user settings.This changes includes of System XAML to the aliased versions instead. It conditionally removes references to versioned System XAML interfaces as well.
Mirrors the following patch in the RNW repo: https://github.com/microsoft/react-native-windows/blob/main/patches/%40react-native-picker%2Bpicker%2B2.1.0.patch