Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed dynamic imports of react-native-web #348

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

maximilize
Copy link
Contributor

The dynamic imports in the web part are causing issues together with react-native-web, electron and vite as bundler.

With a proper configuration, electron disallows the require statement, and it's very tricky to solve this require errors with vite. It's better to use import.

Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Naturalclar Naturalclar changed the title Fixed dynamic imports of react-native-web fix: Fixed dynamic imports of react-native-web Nov 18, 2021
@Naturalclar Naturalclar merged commit 7b49e83 into react-native-picker:master Nov 18, 2021
github-actions bot pushed a commit that referenced this pull request Nov 18, 2021
## [2.2.1](v2.2.0...v2.2.1) (2021-11-18)

### Bug Fixes

* Fixed dynamic imports of react-native-web ([#348](#348)) ([7b49e83](7b49e83))
@Naturalclar
Copy link
Contributor

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants