Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sample): make controls testable in sample #2852

Conversation

freeboub
Copy link
Collaborator

@freeboub freeboub commented Sep 11, 2022

Update the changelog

Fix ChangeLog and add note for this change

Provide an example of how to test the change

Add support of controls toggling in basic sample app

Focus the PR on only one area

Only linked to sample application

@freeboub freeboub merged commit 6625588 into TheWidlarzGroup:master Sep 28, 2022
@evoactivity
Copy link
Contributor

I think this was this removed from the changelog by mistake?

- Android: Add full screen button in default android controls [#2763](https://github.com/react-native-video/react-native-video/pull/2763)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants