Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update autoforms to use graphql mutations for shop settings #202

Closed
1 task
kieckhafer opened this issue Feb 4, 2020 · 1 comment · Fixed by #206
Closed
1 task

Update autoforms to use graphql mutations for shop settings #202

kieckhafer opened this issue Feb 4, 2020 · 1 comment · Fixed by #206
Assignees
@willopez
Milestone
Admin UI

Comments

@kieckhafer
Copy link
Member

kieckhafer commented Feb 4, 2020 •
edited by willopez
Loading

With the removal of the Security meteor package, any autoform forms left in the codebase no longer work. These should all be updated to new form fields that use GraphQL for their mutations.

autoforms remaining, in order of most importance to update:

The mutations for these forms already exist, therefore this is not a blocker for 3.0, but a nice-to-have for the reaction-admin.

Once these are removed, we can remove the aldeed:autoform package.
@kieckhafer kieckhafer transferred this issue from reactioncommerce/reaction Feb 4, 2020
@kieckhafer kieckhafer changed the title autoforms do not work now that alanning:roles is removed Update autoforms to use graphql mutations Feb 4, 2020
@willopez willopez mentioned this issue Feb 6, 2020
Merged
@nnnnat nnnnat added this to the Admin UI milestone Feb 28, 2020
@willopez
Copy link
Member

willopez commented Feb 28, 2020 •
edited
Loading

breaking issue into multiple issues:
#227
#226
#229

@willopez willopez changed the title Update autoforms to use graphql mutations Update autoforms to use graphql mutations for shop settings Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willopez willopez

Labels
None yet
Projects
None yet
Milestone
Admin UI
Development

Successfully merging a pull request may close this issue.

Refactor shop settings forms to use GraphQL reactioncommerce/reaction-admin
3 participants
@willopez @nnnnat @kieckhafer