Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuantityInput: Rewrite QuantityInput to not use MUI components #158

Open
nnnnat opened this issue Jul 24, 2018 · 4 comments
Open

QuantityInput: Rewrite QuantityInput to not use MUI components #158

nnnnat opened this issue Jul 24, 2018 · 4 comments

Comments

@nnnnat
Copy link
Contributor

nnnnat commented Jul 24, 2018

Type: major

Describe the bug
The QuantityInput was ported to the component library from the storefront and is built with MUI components. We'd like to rewrite this component to remove the MUI dependence, either by creating a new component or by adding a similar input addornments feature to our current TextInput component.

@aldeed aldeed added this to the Jupiter milestone Jul 24, 2018
@aldeed
Copy link
Contributor

aldeed commented Jul 24, 2018

Pulling this in to sprint because there are JSS styling problems in production build trying to pull this component into the starter kit app.

@machikoyasuda machikoyasuda changed the title Rewrite QuantityInput to not use MUI components QuantityInput: Rewrite QuantityInput to not use MUI components Jul 25, 2018
@spencern spencern modified the milestones: Jupiter, Kit Carson Aug 7, 2018
@spencern spencern modified the milestones: Kit Carson, Little Bear Aug 21, 2018
@spencern spencern modified the milestones: Little Bear, Massive Sep 4, 2018
@spencern spencern modified the milestones: Massive, North Maroon Sep 18, 2018
@spencern spencern modified the milestones: North Maroon, Oxford Oct 2, 2018
@spencern
Copy link
Contributor

spencern commented Oct 2, 2018

@mikemurray do you know roughly how large this issue is?

@spencern spencern modified the milestones: Oxford, Pikes Peak Oct 18, 2018
@machikoyasuda machikoyasuda removed this from the Pikes Peak milestone Mar 20, 2019
@nnnnat nnnnat removed their assignment Jul 22, 2019
@loan-laux
Copy link
Contributor

I just found out that QuantityInput was the cause of some weird CSS glitches happening only in production on a client's project. Seems to match @aldeed's description. We were trying to use this component on the Reaction Operator UI. Guess we'll hold off for now.

@aldeed
Copy link
Contributor

aldeed commented Jul 30, 2019

@loan-laux Interesting, I thought that issue went away, though I don't know if we ever figured out why QuantityInput was causing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants